Ubuntu

Comment 19 for bug 785425

Steve Langasek (vorlon) wrote :

Hi Louis,

+
+log_begin_msg "Saving vmcore from kernel crash"
+
+mount $rootmnt -o remount,rw
+
 # Make sure makedumpfile assumptions are satisfied.
-while ! test -e "$INFO"; do
+while ! test -e "$rootmnt/$INFO"; do
        panic "kdump: Missing $INFO"
 done
-while ! test -x "$MAKEDUMPFILE"; do
- panic "kdump: Missing $MAKEDUMPFILE"
+
+while ! test -x "$rootmnt/$MAKEDUMPFILE"; do
+ panic "kdump: Missing $rootmnt/$MAKEDUMPFILE"
 done

-log_begin_msg "Saving vmcore from kernel crash"
-
-mount $rootmnt -o remount,rw

This doesn't look like a good change to me. remounting the rootfs read-write before calling panic just increases the chance that we'll have to fsck on the next reboot due to an unclean unmount. Was there a particular reason for this earlier mounting?