Comment 6 for bug 367877

Revision history for this message
Huw Wilkins (huwshimi) wrote :

This is the result of 'outline' being set to 'none' in the css (in combo.css). It's common when doing a css reset to turn remove the outline on links. However, as Alan picked up, this isn't so good for accessibility. There are two ways to go about fixing this.

Option A:
Re-apply the outline after the reset. This would set a uniform style across all browsers.

Option B:
Remove the original outline reset. This would then use the browser default for active items.

I would recommend option B. This is a case where using the browser default is a good thing. Some browsers signify that an item is active with quite different styles and it's probably better to give the user the feedback that they are used to (for example, compare the way Chrome and Firefox do this). Looking at the CSS I can't see a particular reason this is being reset, and removing this shouldn't affect anything else.

I can submit a patch for this, but I just wanted to confirm this decision before I do...