box size doesn't scale correctly in kontact and choqok, and scrollbars appear instead

Bug #1162957 reported by avlas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Choqok
Fix Released
Medium
KDE PIM
Won't Fix
Medium
QtCurve (KDE)
Fix Committed
Undecided
Yichao Yu

Bug Description

I noticed that using qtcurve but not oxygen, boxes containing icons and text misbehave, in particular in kontact and choqok (and maybe others): width and height (respectively) doesn't adapt to the size of the content and a scrollbar appears instead.

Please see the bugs I filled in KDE for Kontact and Choqok:

https://bugs.kde.org/show_bug.cgi?id=317692
https://bugs.kde.org/show_bug.cgi?id=317690

In principal, the problem could be in Qtcurve, or in how the containers of these applications interact with Qtcurve.

Revision history for this message
In , avlas (avlas) wrote :

using oxygen the height of the textbox scales so you can comforttably check all the text while writing. in contrast, in qtcurve you can only see a line and a scrollbar appears, which impedes to check all message at glance

Reproducible: Always

Steps to Reproduce:
1. move from oxygen style to qtcurve
2. write a message in choqok
3. height doesn't change and
Actual Results:
height doesn't change and a scrollbar appears instead

Expected Results:
height should adapt

Revision history for this message
In , avlas (avlas) wrote :

using oxygen icons appear correctly as usual, but with qtcurve only half of them appear (left part). I have to maximize and minimize and then box containing icons properly rescales to the icon size.

Reproducible: Always

Steps to Reproduce:
1. move from oxygen to qtcurve
2. open kontact
3.
Actual Results:
half of the icons can be seen and a scrollbar appears

Expected Results:
box should rescale to the icon size as it does in oxygen

there is this other bug I filled that may indicate something is wrong in how qtcurve and boxes in kde interact:

https://bugs.kde.org/show_bug.cgi?id=317690

it could be the bug is in qtcurve as well. I'm in the process of filling a bug in launchpad for the qtcurve package (I actually don't know where upstream qtcurve resides)

Revision history for this message
In , avlas (avlas) wrote :

It could also be a problem in qtcurve itself, please see:

https://bugs.kde.org/show_bug.cgi?id=317692

Revision history for this message
avlas (avlas) wrote :
Revision history for this message
avlas (avlas) wrote :
Revision history for this message
In , avlas (avlas) wrote :

Created attachment 78552
screenshot

Revision history for this message
In , avlas (avlas) wrote :

Created attachment 78553
screenshot

Revision history for this message
In , avlas (avlas) wrote :
Revision history for this message
In , avlas (avlas) wrote :
Revision history for this message
In , Montel-3 (montel-3) wrote :

It's a problem of theme.
so I close it

Revision history for this message
In , avlas (avlas) wrote :

I'd like to fill a bug upstream then, any indication of where to reach QtCurve developers?

Revision history for this message
In , Christoph-maxiom (christoph-maxiom) wrote :

You can report bugs for QtCurve on the kde-look.org page.

http://kde-look.org/content/show.php?content=40492

Revision history for this message
In , Montel-3 (montel-3) wrote :

For me it's a bug in qtcurve.
It needs to be fix.

Revision history for this message
In , Yyc1992 (yyc1992) wrote :

<email address hidden> :

I am the current maintainer of qtcurve. I cannot really reproduce your issue, i.e. I see no difference on either the inline or popup window for writing new message. Could you please
1. check if the issue is still there
2. your version of qtcurve and choqok
3. your qtcurve compile flag
4. more detail about your problem

P.S. I don't think this is a good place to discuss about qtcurve and I don't like to discuss on kde-look.org either. Could you please report this as an issue on github (github.com/qtcurve/qtcurve-qt4) and discuss there? Thank you.

Revision history for this message
In , Yyc1992 (yyc1992) wrote :

I am the current maintainer of qtcurve and I am trying to look into this bug.
I am able to reproduce this bug with qtcurve but it actually also appears on a lot of other themes that qt ships by default include clearlook, GTK+, Phase, Plastique, Windows. In fact, there are more themes that has this problem (the ones listed above plus QtCurve) than the ones that do not have the problem (CDE, Motif, Oxygen). I do think this is probably a bug in the themes but I am just wondering what kontact is doing that makes this many themes unhappy.

Revision history for this message
In , avlas (avlas) wrote :

Thanks Yichao Yu for trying to fix the issue!

1. Yes I still see the problem in both the inline and the popout window.
2. I'm using qtcurve (1.8.14), the new version of choqok (1.4), kde (4.11.2) and kubuntu (13.10).
3. I use deb packages from kubuntu, but I tried compiling from the git source you indicated with identical result.
4. There is no much more to explain, I just open choqok and try to write a message. Using oxygen the textbox rescales so you can see all your text. When using qtcurve, the window still rescales but so tiny bits that you cannot see more than a single line and the vertical scrollbar appears.

I'm opening an issue in github to continue discussion there...

Revision history for this message
In , Yyc1992 (yyc1992) wrote :

Update from QtCurve:
It turns out that this is because choqok uses the minimum height of the scrollbar for the height of the input area, making it theme and setting dependent.
I have added a lower limit on the size in QtCurve so this shouldn't be a problem anymore. However, maybe it is better or more reliable for choqok to support different settings and themes if the size is calculated from the font size.

Revision history for this message
Yichao Yu (yuyichao) wrote :

Hi,

I'm the current QtCurve maintainer and here is what I have figured out about the bug now.

Both of them are because the application is using the minimum size of the scrollbar as the size of the box and therefore for a narrow scrollbar which had a small minimum size the size of the box is also small.
For choqok, it is currently workarounded in QtCurve by setting a lower limit of the minimum length but this should still be fixed in choqok since it WILL break even in oxygen if the user has a bigger font than the default one.
For kontact, the same workaround fixes the problem for that user since he is also using a narrow sidebar which is thinner than the lower limit of scrollbar in QtCurve right now. However, for a wider sidebar (e.g. the default one with big icon and text) even more than half of the Qt default themes have the same problem. It makes no sence to rely on the scrollbar size in kontact since it is definitely using some other way to calculate the size and the problem should be fixed in kontact.

More info can be found in the kde bug reports pointed out by the original reporter as well as the QtCurve bug report here[1]. The workaround can be found in that bug report or here[2]. This patch will be included in the coming QtCurve release (the should be one in at most 2 month, likely even earlier.)

Please close this bug or assign it to Choqok and Kontact.

Thanks.

[1] https://github.com/QtCurve/qtcurve-qt4/issues/7
[2] https://github.com/QtCurve/qtcurve-qt4/commit/8889ee355af6c0f0e315f75ef0afde130d7dcde9

Revision history for this message
In , Yyc1992 (yyc1992) wrote :

The problem is indeed in Kontact itself rather than QtCurve although the user's custom setting makes it easier to see. The real problem is that Kontact is (directly or indirectly) using the minimum size of the scrollbar to calculate the initial size of the sidebar content, which is different in different themes.

I believe kontact has other ways to calculate the right width since it can correctly reserve space for the sidebar and the size is correct after resizing the window.

The problem should be fixed in kontact especially because the problem also appears in more than half of the Qt default themes.

How can I request reopenning this bug?

Revision history for this message
In , Yyc1992 (yyc1992) wrote :
Revision history for this message
In , Yyc1992 (yyc1992) wrote :

More update:

This should be fixed in choqok. Setting a minimul length of the scrollbar cannot fix the problem completely and it is actually also broken in oxygen if the user has a larger font than default.

How can I request reopenning this bug?

Revision history for this message
In , Yyc1992 (yyc1992) wrote :
Revision history for this message
Yichao Yu (yuyichao) wrote :

Workaround committed. Need to be fixed in the application.

no longer affects: kde-style-qtcurve
affects: kde-style-qtcurve (Ubuntu) → kde-style-qtcurve
Changed in kde-style-qtcurve:
assignee: nobody → yuyichao (yyc-1992)
status: New → Fix Committed
Changed in choqok:
importance: Unknown → Medium
status: Unknown → Won't Fix
Changed in kdepim:
importance: Unknown → Medium
status: Unknown → Won't Fix
Changed in choqok:
status: Won't Fix → Confirmed
Revision history for this message
In , Yyc1992 (yyc1992) wrote :
Revision history for this message
In , Yyc1992 (yyc1992) wrote :

Should be fixed with the merged review request.

Changed in choqok:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.