Comment 32 for bug 730672

Revision history for this message
In , Dustin (dustin-redhat-bugs) wrote :

Awesome! Thanks for the response. I was worried this bug/patch might have gotten dumped into the bit bucket.

Regarding the format of the file, I just went for the simplest approach, from the perspective of reading the values in the C code. I didn't expect this to be something that people changed often, frequently, or on their own. I expected more that a distro or a packager would do this, and probably only ever do it once or twice, so I didn't really think about it in terms of a user-friendly interface, but instead, just as a "functional" one.

Regarding the default path, yes, of course, that could (and should?) very well be configurable. /etc/newt/colors seemed to me like a simple, straightforward, obvious default.

Regarding a "NEWT_COLORS" environment variable, that's an excellent idea, such that the color scheme could even be modified on an application-by-application, or process-by-process basis (rather than system wide).

I'm concerned a little bit by the complexity of the code necessary to process the descriptive configuration file and/or environment variable. At this point, I would prefer for you to point me to a git branch with your implementation of these, and I'll gladly build/test that, and port over Ubuntu's use of this functionality to your new implementation.

Cheers,
Dustin