Comment 30 for bug 1545913

On Sat, Apr 09, 2016 at 10:32:43PM -0000, Martin Packman wrote:
> Sadly, being stuck in -proposed is probably correct for beta3, due to
> the above mentioned lxd breakages.

It may be the case that the package should be stuck in -proposed, but not
for these test failures, which are very clearly bugs in the tests and not in
the juju-core code. The tests, not the lxd code, call adduser and fail
because they have not declared that root privileges are needed.

It is also not the expectation that known-broken packages be uploaded to
xenial-proposed and allowed to linger there. Please fix these tests ASAP
and reupload.

> Note that the future-lxd-provider gets futher, but still breaks due to
> changes in lxd since the test was last modified with beta2:

> + lxd-images import ubuntu yenial --alias ubuntu-yenial
> debian/tests/lxd-provider: line 8: lxd-images: command not found

Yes, you're right, I overlooked that the error message here was different -
sorry about that. This is also a test bug (because incompatible with
current lxd-client) that needs fixing. If I'm not mistaken, the current
syntax for this is 'lxc image import ubuntu $SERIES --alias ubuntu-$SERIES'.

Also, the tests are missing a declaration for their dependency on the
lxd-client package. It definitely won't be installed in the autopkgtest
testbed without this declaration.

> Also, we don't have coverage for lxd on armhf or s390x as they can't
> provide machine-level isolation. That's probably fine, but can maybe be
> improved when we have more confidence lxd/juju won't blow things up as
> much as the dev versions have tended to.

Unless the tests themselves actually require machine-level isolation, I
would suggest that the 'breaks-testbed' restriction that's been declared is
sufficient, and there's no need to specify 'isolation-machine' as well - and
that you can leave it to the autopkgtest implementors to ensure that the
testbed is appropriately isolated.

(If Martin Pitt has specifically requested that you use the
'isolation-machine' restriction, then I defer to him.)