Comment 4 for bug 993304

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

* Builds on quantal with only main
* Like Colin said, there is a test suite and it uses modern packaging techniques with a watch file, no Ubuntu delta
* package is up to date with no CVE history
* lintian clean
* nothing in the packaging which would require a security audit

The package does have the following compiler warnings:
pbmtojbg.c:305:10: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
pbmtojbg.c:318:12: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
pbmtojbg.c:91:11: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
jbgtopbm.c:113:5: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat]
jbgtopbm.c:138:6: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat]
jbgtopbm.c:192:6: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat]
jbgtopbm.c:197:7: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:202:7: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:213:3: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:222:2: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:225:2: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:245:2: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:254:2: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:263:2: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long int' [-Wformat]
jbgtopbm.c:376:6: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat]
pbmtojbg85.c:242:12: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
pbmtojbg85.c:75:11: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
tstcodec.c:403:7: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat]
tstcodec.c:415:5: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat]
tstcodec.c:443:7: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat]
tstcodec.c:455:5: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat]
tstcodec85.c:338:7: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat]
tstcodec85.c:350:5: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat]
tstcodec85.c:378:7: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat]
tstcodec85.c:390:5: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat]

Some of these are probably not a problem (eg, int and size_t are the same size on i386 and amd64, didn't check other architectures), but unsigned int and long int are different sizes on amd64 (4 vs 8). I didn't look into the -Wformat warnings except to see that they were in error messages. Can someone get these cleaned up or verify/document they are not a problem? Once that is done, ACK.