Comment 27 for bug 1805920

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I'm glad that the ipxe in the PPA seems to make it work.

I now read the discussions and all questions that came up for me while doing so were asked and clarified already in later comments.

Therefore I just reviewed the proposed change and it looks good to me (other than the version string but that was just for the PPA, so that is ok).

Only one question to be sure:
I was only wondering if this might trigger any issues in iscsi booting since the change in src/net/netdevice.c adds the stripping to the generic net_poll. Now the (old) commit [1] reads as that would be required to be set. I wonder if there would be any regression in that regard.
I remember words iSCSI+Mass being used together, but I'm unsure if the stack these days still uses it. When Vern confirmed that he could deploy with the modified ipxe, did that include a iSCSI boot?

If not could one of you just double-check that iSCSI boot didn't regress due to this change?

[1]: https://git.ipxe.org/ipxe.git/commit/7d64abbc5d0b5dfe4810883f372b905a359f2697