Comment 7 for bug 234302

Revision history for this message
Daniel J Blueman (danielblueman) wrote :

This patch fixes the behaviour:

--- ./ipmitool-1.8.8/src/plugins/lanplus/lanplus.c 2006-04-21 17:34:30.000000000 +0100
+++ ./ipmitool-1.8.8-dan/ipmitool-1.8.8/src/plugins/lanplus/lanplus.c 2008-05-30 18:12:02.000000000 +0100
@@ -2165,6 +2165,8 @@

    rsp = ipmi_lanplus_recv_sol(intf); /* Grab the next packet */
+ if (!rsp)
+ break;

    if (sol_response_acks_packet(rsp, payload))
     break;
@@ -2456,7 +2458,7 @@
 {
  struct ipmi_rs * rsp = ipmi_lan_poll_recv(intf);

- if(rsp->session.authtype != 0)
+ if(rsp && rsp->session.authtype != 0)
    {
     ack_sol_packet(intf, rsp);

Now, the session is terminated after it is timed out:

$ ipmitool -A MD5 -o intelplus -I lanplus -e [ -P fooey -H quorum1-mc sol activate 1
[SOL Session operational. Use [? for help]
<terminate from other command>
Error sending SOL data: FAIL
SOL session closed by BMC
$

Can someone kick this upstream?