Comment 2 for bug 1881074
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Some comments on the debdiff:
Use
blkid -s TYPE "$writable_part" -o value
instead of
blkid -s TYPE "$writable_part" | awk '{print $2}' | grep -o '".*"' | tr -d '"'
No need to redirect to >>$LOGFILE in resize_filesystem() which is already redirected when called. Also, you should not redirect to /dev/kmsg - I guess that was for debugging purposes.
Is it really necessary to mount the partition to find out the filesystem usage?
"btrfs filesystem show" apparently can work on devices according to [1]. But it also looks like btrfs commands are mostly used with mounted systems, so it is fine if you want to keep things like that.
Finally, you will need to use copy_exec for btrfs and blkid to the fixtrtc hook to get them included in the initramfs (although maybe blkid comes from busybox in this case, not sure).
Otherwise, looks good to me.
[1] https:/