Comment 15 for bug 436887

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Just to clarify, the reason the patch is needswork is that the only things it does I think are bad ideas. It removes titles from alerts that should have them, it adds redundant keys for buttons that are already triggered by Escape and Enter.

There's a valid bug here, that the alerts and the HIG's guidelines for alerts don't agree. I think this is a bug in the HIG, not the alerts, and I'll work to adjust the HIG accordingly. A useful part of that process will be demonstrating that the new proposed behavior works. For example, "the Cancel buttons in Ubuntu's logout and shutdown alerts respond only to the Escape key, not any other key, and no-one is confused". If that was fixed in the HIG and in GTK's stock Cancel button, then these alerts could return to using GTK's stock Cancel button.

For the moment, though, I think removing "skip-pager-hint" and "skip-taskbar-hint" from the alerts is the only code change we want here. Thanks for pointing it out.