Proposed fix tested successfully on AWS with and without the address-allocation feature flag - no regressions. On MAAS 1.9.3 and trusty nodes the infamous /etc/network/interfaces.d/eth0.cfg:
auto eth0
iface eth0 inet dhcp
which is sourced by /etc/network/interfaces ('source /etc/network/interfaces.d/*.cfg') still caused issues. Similarly on xenial, with the equivalen '50-cloud-init.cfg'. Both of these are part of the cloud images, and cause issues because the 'eth0' gets a DHCP address IN ADDITION TO its static address allocated by MAAS.
So the fix in comment #7 now omits the 'source' stanza from the modified /e/n/i and avoiding the issue. Pending confirmation from Lorenzo, the fix is approved and can land.
Proposed fix tested successfully on AWS with and without the address-allocation feature flag - no regressions. On MAAS 1.9.3 and trusty nodes the infamous /etc/network/ interfaces. d/eth0. cfg: interfaces ('source /etc/network/ interfaces. d/*.cfg' ) still caused issues. Similarly on xenial, with the equivalen '50-cloud- init.cfg' . Both of these are part of the cloud images, and cause issues because the 'eth0' gets a DHCP address IN ADDITION TO its static address allocated by MAAS.
auto eth0
iface eth0 inet dhcp
which is sourced by /etc/network/
So the fix in comment #7 now omits the 'source' stanza from the modified /e/n/i and avoiding the issue. Pending confirmation from Lorenzo, the fix is approved and can land.