Translation template for ibus is missing some strings

[AsciiWolf]

There are some strings missing in the translation template for ibus, at least in my (Czech) language. For example these strings:

#: ../setup/setup.ui.h:50
msgid "Emoji choice:"
msgstr "Výběr emoji:"

#: ../setup/setup.ui.h:51
msgid "Set a font of emoji candidates on the emoji dialog"
msgstr "Nastavit písmo kandidátů emoji v dialogu emoji"

#: ../setup/setup.ui.h:52
msgid "Emoji font:"
msgstr "Font emoji:"

#: ../setup/setup.ui.h:53
msgid "Set a language of emoji annotations on the emoji dialog"
msgstr "Nastavit jazyk anotací emoji v dialogu emoji"

#: ../setup/setup.ui.h:54
msgid "Emoji annotation language:"
msgstr "Jazyk anotací emoji:"

They are fully translated upstream, but are missing on Launchpad and are untranslated in Ubuntu 18.04 (see the attached screenshot).

But there are more strings missing.

[Gunnar Hjalmarsson (gunnarhj)]

Thanks for your report!

Right, the LP template was almost three years old. I created and uploaded a new template for now. That ought to help a bit. But it resulted in 64 untranslated strings, which indicates that the upstream PO files were created with an old template.

3 days before deadline. Some translators will hate me...

Looking at the build log, dh_translations isn't mentioned and - consequently - the latest translation tarball is without a POT file.

@Sebastien: What determines whether dh_translations should be run when building?

[Gunnar Hjalmarsson (gunnarhj)]

I noticed that dh-translations is not in Build-Depends, so I added cdbs to Build-Depends to pull it and uploaded to PPA, but the dh_translations program was still not run according to the build log.

[AsciiWolf (asciiwolf)]

Should I add the missing Czech translated strings manually?

[Gunnar Hjalmarsson (gunnarhj)]

Not sure. Possibly a no-change rebuild would make a difference now when an up-to-date template is in. But for that we need a developer who has time to do it by tomorrow. You may want to wait another day before doing it manually.

[Gunnar Hjalmarsson (gunnarhj)]

Or, even better, a real upload which fixes the issue also going forward. :) Sebastien let me know on IRC what's needed, so I wrote a patch.

[Sebastien Bacher (seb128)]

The use of dh-translations was removed without explanation in that upload
http://launchpadlibrarian.net/227995812/ibus_1.5.10-1ubuntu1_1.5.11-1ubuntu1.diff.gz

I just did an upload adding the build-depends and rules translations use

[Launchpad Janitor (janitor)]

This bug was fixed in the package ibus - 1.5.17-3ubuntu4

---------------
ibus (1.5.17-3ubuntu4) bionic; urgency=medium

  * debian/control, debian/rules:
     - restore use of dh_translations which was removed in 1.5.11-1ubuntu1
       without explanation (lp: #1764161)

 -- Sebastien Bacher <email address hidden> Tue, 17 Apr 2018 19:43:24 +0200

[Gunnar Hjalmarsson (gunnarhj)]

The missing upstream translations seem to have been successfully imported to LP through that upload.