We don't need to change all instances of putenv() to setenv(), just the one we are changing is needed. This is the only one in hwloc itself using putenv(), all other instances are in tests and utils / tools.
>> You might want to scrub the HWLOC code and replace all instances of "putenv" with "setenv".\
> Don't worry, there are no putenv in libhwloc except this new one for L0. Others are in tools and tests, where putenv() is easier because it works on Windows.
We will stick with upstreams decision for this bug.
Hi Dan,
We don't need to change all instances of putenv() to setenv(), just the one we are changing is needed. This is the only one in hwloc itself using putenv(), all other instances are in tests and utils / tools.
As per the maintainer in https:/ /github. com/open- mpi/hwloc/ pull/514# issuecomment- 1024642432:
>> You might want to scrub the HWLOC code and replace all instances of "putenv" with "setenv".\
> Don't worry, there are no putenv in libhwloc except this new one for L0. Others are in tools and tests, where putenv() is easier because it works on Windows.
We will stick with upstreams decision for this bug.
Thanks,
Matthew