[FFe] Add Intel RAID/RST detection with NVMe devices

[Woodrow Shen]

[Impact]

If the system has "Intel RST" mode enabled, we can't see its disks because there is no support in the Linux kernel for them.

We can detect this situation and tell the user, directing them to documentation which tells them how to work around it.

[Test Case]

On a system (probably bare metal), turn on RST/Intel RAID mode and try to install from Ubiquity (GTK frontend only). You should see a page directing you to documentation (to be created).

[Regression Potential]

Some case will be different, especially the system doesn't have AHCI when RAID mode was set in BIOS, so that PCI attribute "remapped_nvme" is gone.

[Iain Lane (laney)]

What Ubiquity needs to know is not if there are *any* remapped NVME drives. It needs to know if there are *only* those. Like, if I connect a USB-C drive and wanted to install onto that (to dual boot), I should be able to still install.

Unless I'm really wrong on this...

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "hw-detect_1.117ubuntu8.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Woodrow Shen (woodrow-shen)]

Hi Iain,

The point for this patch is to identify if RAID/RST mode is enabled or not. Based on this, ubiquity should consider any case in which the user is able to install Ubuntu indeed. In your case, I think ubiquity can use is_removable (https://git.launchpad.net/ubiquity/tree/ubiquity/misc.py#n230) function to check if external USB / USB-C drive is plugged or not, except for USB boot device.

[Dimitri John Ledkov (xnox)]

Is the attached debdiff complete?

It adds a function, but nothing calls it. Is there any missing new files for example that call that function.

[Woodrow Shen (woodrow-shen)]

I'm trying to extract the function as a new script due to the possible case: (please rectify if I'm wrong):

disk-detect.sh seems not to be used in the ubiquity (but disk-detect.sh will be called in the post-installation)

I think the possible call sequence will be like: ubi-partman -> discover-remapped-nvme.sh -> ubi-partman gets the value via db.get('disk-detect/activate_remapped_nvme') -> respond to dialog.

[Iain Lane (laney)]

Let's use this for the FFe.

[Shih-Yuan Lee (fourdollars)]

I have updated https://code.launchpad.net/~fourdollars/ubiquity/+git/ubiquity/+merge/382079 to include the fix.

[Łukasz Zemczak (sil2100)]

This looks fine, as it feels to me more of a bugfix than a feature. This will change the UI, so I consider this as a request more of an UIFe. Anyway, exception granted.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubiquity - 20.04.11

---------------
ubiquity (20.04.11) focal; urgency=medium

  [ Shih-Yuan Lee (FourDollars) ]
  * Add the detection logic for Intel RST RAID. (LP: #1864965)

  [ Iain Lane ]
  * ubi-partman: Make 'back' work from the RST page. Previously it went back
    to the prepare page. We actually want to go back to the partitioning page.
  * Implement bitlocker UI. Check if a partition has type 'BitLocker', and
    show the error page if it does and we're trying to resize. Thanks to
    Woodrow Shen and Shih-Yuan Lee for their work here too. (LP: #1872718)
  * Automatic update of included source packages: shim-signed 1.40.

  [ Rik Mills ]
  * KDE: Kubuntu has dropped the KDE PIM suite from the default install
    for 20.04. Remove KDE PIM mention from the software selection page.

 -- Iain Lane <email address hidden> Tue, 14 Apr 2020 18:57:04 +0100