© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Andy asked me to have a look, so here's my initial feedback.
General
=======
I'm not sure if these changes should be backported to Artful too, to maintain the upgrade path for users transitioning off Xenial. Could you please ask the SRU team?
Otherwise, the changes are risky but I think they should be in principle okay.
The test cases and regression potential in the description here could do with fleshing out a bit - could you do that please? For example, snapcraft depends on pymacaroons - probably want to make sure that keeps working. And it is supposed to be compatible, but that doesn't mean there is no bug in the newer version - it is a regression potential IMO.
httmock
=======
Since this is completely new and a no-change backport, I think it's okay. Uploaded.
protobuf
========
I'm a bit worried about bugs coming from the use of 2to3 which is best used as a starting point for a manual port, not for an automatic conversion - how about taking the upstream patches instead?
https:/
https:/
https:/
I tried the testsuite with this and it works after resolving some minor conflicts.
pymacaroons
===========
Seems okay if it's compatible - can you check with Colin please? I'm happy to handle the actual upload.
py-macaroon-bakery
==================
I'm not qualified to review this - maybe also check with Colin as the maintainer? The patch says it's editing a generated file - is that right?