Comment 0 for bug 13323

Revision history for this message
In , Jan Echternach (jan-goneko) wrote :

Package: hotplug
Version: 0.0.20040329-17
Severity: grave
Tags: patch
Justification: renders package unusable

"/etc/init.d/hotplug start" aborts almost immediately, it doesn't even
print the "Starting hotplug subsystem" message. I didn't notice this
until I tried to use an USB device and found that no USB modules
were loaded. Other modules like hw_random had not been loaded either.

I've tracked it down to an 'unset' call failing, apparently because the
variable to be unset hasn't been set in the first place. This simple
patch made it work again:

--- hotplug-orig Wed Feb 16 01:40:28 2005
+++ hotplug Sun Feb 27 12:23:29 2005
@@ -24,7 +24,7 @@
 # $prune_output (the list with the elements removed) and $prune_discard
 # (the list of the elements discarded).
 prune() {
- unset prune_output prune_discard
+ unset prune_output prune_discard || :
     local discard

     for x in $1; do
@@ -55,7 +55,7 @@
     # Append it to the new list, knowing that dependancies are satisfied.
     echo "$sorted_list $prune_discard"

- unset prune_output prune_discard
+ unset prune_output prune_discard || :
 }

 quiet_printk() {
@@ -132,7 +132,7 @@
     ;;

 status)
- unset QUIET
+ unset QUIET || :
     run_rcs $1 "Hotplug status"
     ;;

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux ogar 2.6.10-1-686 #1 Tue Jan 18 04:34:19 EST 2005 i686
Locale: LANG=C, LC_CTYPE=de_DE

Versions of packages hotplug depends on:
ii debconf 1.4.46 Debian configuration management sy
ii grep 2.5.1.ds1-4 GNU grep, egrep and fgrep
ii module-init-tools 3.2-pre1-2 tools for managing Linux kernel mo
ii modutils 2.4.26-1.2 Linux module utilities
ii procps 1:2.0.7-8.woody1 The /proc file system utilities.