Comment 164 for bug 95444

Revision history for this message
Bem Jones-Bey (ajani) wrote :

First off thanks to everyone contributing to this bug, I've found the information very helpful, especially to Shawe since without those scripts, I wouldn't even have had the foggiest idea how to get the hotkeys working. =]

My laptop is a HP 8510w, so Shawe's scripts don't work out of the box for me. I ended up adding my model to the FDI file, and things pretty much work. In the process, I also made the HAL scripts less Sony specific.

I've packaged up my modified files here: http://testing.pyen.com/~ajani/nvidia8-fnkeys.tar.bz2

Shawe, I'm especially interested in what you think of my changes, and if other could tell me if this works for them, that would be great, too.

I do have one question: I didn't make any changes to the acpid scripts; my model uses /etc/acpi/video_brightness{down,up}.sh. Do those only need to be changed so that the brightness keys will work when not in Gnome?

Here's a list of the changes that I've made:

* replaced 'sony' with nvidia8, to make it more obvious that it's not sony specific
* changed the access method name to nvidia8 because it now supports non-sony models
* moved the check for the nvidia8 laptop panel access method to the top of the hal get and set scripts so that the check fot /sys/class/backlight doesn't have to be commented out. This should make it easier to incorporate these changes into the hal packages.
* install script:
  - changed script to use dpkg-divert to make backups of replaced files so that upgrades of the packages for those files won't break the setup
  - removed 'make install' step, since it isn't needed
  - changed chmods on scripts to be 755, so that other and group get executable bit
  - change chmod on the fdi to be 644, since it doesn't need to be executable
  - added a 'sudo' in front of every command that needs root priviledges so that I can run the script as my normal user
  - All of the files except nvclock source are included in the tarball, so it doesn't download anything except nvclock
* Added an uninstall script