Comment 3 for bug 2002152
Revision history for this message
| dann frazier (dannf) wrote Re: hg-git: bionic autopkgtests fails due to extraneous git output | #3 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Andreas. Thank you for your careful review.
I chose to pull the entire patch from upstream instead of crafting a targeted fix myself. That would have been more clear had I included DEP-3 headers in the patch - and I think I should reupload w/ that added, even if nothing else. Here's a link in the meantime:
https:/
Since that changeset technically addresses 2 different issues (return code and extra output), I did consider dropping the return code piece. I'm happy to do that if you prefer (and it sounds like you do). Arguments for keeping it would be that it is more portable, and no less permissive than what we have in later releases. But of course, we're not experiencing the return code issue, so addressing it here is in conflict with the idea of a surgical fix.
I would prefer to retain the optional error message support though - I don't see a good reason for being more restrictive than upstream there, and doing so should help avoid conflicts if we need to backport additional changes in this area.
So to summarize, I suggest I reupload by adding DEP-3 headers to the patch and dropping the return code portion of the patch. What do you think?