Strings in the *mako templates are not translatable

[Gabor Kelemen]

Binary package hint: gwibber

There are translatable strings in the ui/templates/*mako files. These are mixes of Python and HTML code - adding _() calls to the Python seems to work, but for HTML, it does not. I have no idea how these could be translated in a sensible way.

[Pedro Villavicencio (pedro)]

Confirmed there's a few strings there which are untranslated, this need to be looked by a gwibber developer, marking it as triaged, thanks.

[Ryan Paul (segphault)]

What strings in the Mako templates can't be translated? It should be possible to wrap _() around pretty much anything in there.

[Gabor Kelemen (kelemeng)]

Currently, nothing is marked for translation, and the files are not present in the POTFILES.in file.

I'll attach some patches to show them - but I was not joking when I said that _() does not work for the HTML parts :(.

[Gabor Kelemen (kelemeng)]

Here they are, some of these will show up translated, but not all.

[Gabor Kelemen (kelemeng)]

Running intltool-update results in this:

$ grep -A1 mako hu.po
#: ../ui/templates/base.mako:98
msgid "from"
--
#: ../ui/templates/base.mako:101
msgid "in reply to"
--
#: ../ui/templates/targetbar.mako:7
msgid "Replying to {0} as {1}"
--
#: ../ui/templates/targetbar.mako:8
msgid "Reposting from {0} as {1}"

The other strings were not extracted :(.

[Gabor Kelemen (kelemeng)]

Ok, this can be a lot better, if I don't mess it up :).

Turns out that only at the end of targetbar.mako are html parts, namely

          <div class="label">_("Send with:")</div>

<img class="icon" title="_("${account['protocol']} (${account['username']}) - Disabled")" src="${breakdance(account['protocol'])}" />

These are the only problematic parts.

[Heikki Mäntysaari (heikki-mantysaari)]

Translation deadline is quite soon (22.4.), is it possible to get this fixed (just apply the patch?) in time so that we can translate that highly visible string ("Send with:") before the deadline?

[Gabor Kelemen (kelemeng)]

Hey, thanks for the fix, but the strings I called problematic above, were really problematic - at least, I saw them appear literally on the ui, like: _("Send with:") - the other was even worse.
Could someone check if this is still the case? I only marked them for translation to highlight them, not because this worked.

[Ken VanDine (ken-vandine)]

Yeah, I committed a fix for that separately, thanks for the patch!

[Gabor Kelemen (kelemeng)]

Cool, and for the title=("${account['protocol']} (${account['username']}) - Disabled") one? :)

[Ken VanDine (ken-vandine)]

Ah, missed that one. Just pushed a fix for that too, thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package gwibber - 2.30.0-0ubuntu1

---------------
gwibber (2.30.0-0ubuntu1) lucid; urgency=low

  * New upstream release
    - gwibber crashed with KeyError in action() (LP: #520492)
    - Strings in the side panel are not translatable (LP: #538981)
    - Strings in the *mako templates are not translatable (LP: #538987)
    - gwibber crashed with AttributeError in action() (LP: #444654)
 -- Ken VanDine <email address hidden> Wed, 14 Apr 2010 16:22:09 -0400