Strings from ui files do not show up translated

Bug #538846 reported by Gabor Kelemen on 2010-03-14
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Gwibber
Medium
Ken VanDine
Ubuntu Translations
High
Unassigned
gwibber (Ubuntu)
Low
Ken VanDine

Bug Description

Binary package hint: gwibber

Lots of strings do not show up translated, even if they are in the mo file. These are from the ui files and the reason is that the translation domain is not explicitly specified with set_translation_domain() for the ui files.

The affected files:

grep -rC2 add_from_file *
gwibber/client.py-
gwibber/client.py- def on_about(self, *args):
gwibber/client.py: self.ui.add_from_file (resources.get_ui_asset("gwibber-about-dialog.ui"))
gwibber/client.py- about_dialog = self.ui.get_object("about_dialog")
gwibber/client.py- about_dialog.set_version(str(VERSION_NUMBER))
--
gwibber/accounts.py- self.pub = gwibber.lib.GwibberPublic()
gwibber/accounts.py- self.ui = gtk.Builder()
gwibber/accounts.py: self.ui.add_from_file (resources.get_ui_asset("gwibber-accounts-dialog.ui"))
gwibber/accounts.py- self.ui.connect_signals(self)
gwibber/accounts.py- dialog = self.ui.get_object("accounts_dialog")
--
gwibber/lib/gtk/identica.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/identica.py- self.ui = gtk.Builder()
gwibber/lib/gtk/identica.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-identica.ui"))
gwibber/lib/gtk/identica.py- self.ui.connect_signals(self)
gwibber/lib/gtk/identica.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/friendfeed.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/friendfeed.py- self.ui = gtk.Builder()
gwibber/lib/gtk/friendfeed.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-friendfeed.ui"))
gwibber/lib/gtk/friendfeed.py- self.ui.connect_signals(self)
gwibber/lib/gtk/friendfeed.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/flickr.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/flickr.py- self.ui = gtk.Builder()
gwibber/lib/gtk/flickr.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-flickr.ui"))
gwibber/lib/gtk/flickr.py- self.ui.connect_signals(self)
gwibber/lib/gtk/flickr.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/digg.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/digg.py- self.ui = gtk.Builder()
gwibber/lib/gtk/digg.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-digg.ui"))
gwibber/lib/gtk/digg.py- self.ui.connect_signals(self)
gwibber/lib/gtk/digg.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/facebook.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/facebook.py- self.ui = gtk.Builder()
gwibber/lib/gtk/facebook.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-facebook.ui"))
gwibber/lib/gtk/facebook.py- self.ui.connect_signals(self)
gwibber/lib/gtk/facebook.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/statusnet.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/statusnet.py- self.ui = gtk.Builder()
gwibber/lib/gtk/statusnet.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-statusnet.ui"))
gwibber/lib/gtk/statusnet.py- self.ui.connect_signals(self)
gwibber/lib/gtk/statusnet.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/twitter.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/twitter.py- self.ui = gtk.Builder()
gwibber/lib/gtk/twitter.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-twitter.ui"))
gwibber/lib/gtk/twitter.py- self.ui.connect_signals(self)
gwibber/lib/gtk/twitter.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/lib/gtk/qaiku.py- gtk.VBox.__init__( self, False, 20 )
gwibber/lib/gtk/qaiku.py- self.ui = gtk.Builder()
gwibber/lib/gtk/qaiku.py: self.ui.add_from_file (gwibber.resources.get_ui_asset("gwibber-accounts-qaiku.ui"))
gwibber/lib/gtk/qaiku.py- self.ui.connect_signals(self)
gwibber/lib/gtk/qaiku.py- self.vbox_settings = self.ui.get_object("vbox_settings")
--
gwibber/preferences.py- def __init__(self):
gwibber/preferences.py- self.ui = gtk.Builder()
gwibber/preferences.py: self.ui.add_from_file (resources.get_ui_asset("gwibber-preferences-dialog.ui"))
gwibber/preferences.py- self.ui.connect_signals(self)
gwibber/preferences.py- self.gc = gconf.client_get_default()

Gabor Kelemen (kelemeng) on 2010-03-14
Changed in ubuntu-translations:
status: New → Triaged
David Planella (dpm) on 2010-03-15
Changed in ubuntu-translations:
importance: Undecided → High
tags: added: patch
Pedro Villavicencio (pedro) wrote :

Thanks for the report, Ken may you have a look into this ? Thanks.

Changed in gwibber (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
importance: Undecided → Low
status: New → Triaged
Changed in gwibber:
assignee: nobody → Ken VanDine (ken-vandine)
importance: Undecided → Medium
milestone: none → 2.30.0
status: New → Fix Committed
Changed in gwibber (Ubuntu):
status: Triaged → Fix Committed
milestone: none → ubuntu-10.04-beta-2
David Planella (dpm) on 2010-03-24
tags: added: gwibber-i18n
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gwibber - 2.29.93-0ubuntu1

---------------
gwibber (2.29.93-0ubuntu1) lucid; urgency=low

  * New upstream release
    - Use MAX_MESSAGE_LENGTH for max length instead of hard coding 140
    - Changed the views to not emit the entire doc as a value
    - Set default focus to the text input widget (LP: #528302)
    - Made a string translatable, requested by the translations
      team (LP: #534667)
    - Patch from Gabor Kelemen setting translation domain for .ui
      files (LP: #538846)
    - Mark strings translatable, thanks Kelemen Gábor (LP: #520462)
    - Added X-GNOME-Gettext-Domain to allow translations of the desktop
      files to be loaded at runtime (LP: #538851
    - Use the desktopcouch API for excluding the DB and handle
      errors (LP: #539583)
    - Set window icons properly so they scale nicely
    - Set account IDs in desktopcouch to force merging on sync instead of
      creating dupes (LP: #535263)
  * debian/patches/lp_report_to_ubuntu.patch
    - File bugs against the package (LP: #551132)
 -- Ken VanDine <email address hidden> Wed, 17 Mar 2010 13:20:24 -0400

Changed in gwibber (Ubuntu):
status: Fix Committed → Fix Released
Omer Akram (om26er) on 2010-03-30
Changed in gwibber:
status: Fix Committed → Fix Released
David Planella (dpm) on 2010-04-13
Changed in ubuntu-translations:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers