© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Thanks Etienne. Someday I'm going to learn how to use Launchpad PPA!
As for the fix, I'll say this: first, the concept behind the patch is unquestionably 100% correct. As you point out, it's fundamentally wrong to look for .Trash directories in automount points, because they aren't "real" directories. It's like trying to look for /proc/.Trash or /sys/.Trash or something... except worse because this lookup actually does more than just fail with ENOENT.
Second, I'm 99% sure that the patch does do what I expected it to do, and that it works properly. I'm definitely no expert in glib but this change seems very straightforward.
Third, as I mentioned above I'm confident that this is not the most elegant way to solve the problem. However, it may be worthwhile to keep this as an Ubuntu patch, even if upstream Gnome folks don't want to apply it there, until they work out and implement the more elegant solution.