> * -doc package: I think we should promote it as well in main ... If so, this dep should be fixed: Depends: lynx | www-browser
Done, changed to a Suggests: devhelp
> I think the build-dep on libgupnp-1.0-dev may thus be optional
Seems to be indeed, no difference without it, I removed it
> * debian/copyright has some missing copyright notices:
> Copyright: 2012-2013 Intel Corporation for instance in * as GPL-2.0+
Thanks, fixed now
> * 2 of the 4 lintian warning worth fixing IMHO:
> W: libgupnp-dlna-2.0-dev: gir-missing-typelib-dependency usr/share/gir-1.0/GUPnPDLNAGst-2.0.gir gir1.2-gupnpdlnagst-2.0 -> dep from the -dev on the gir*
That's a bit tricky, there is no corresponding gir (which is the cause for the other lintian warning), they preferred to bundle the gir in the same binary and use a provide, in that context I don't think adding the depends makes sense? would you be ok with a lintian override?
> W: gir1.2-gupnpdlna-2.0: typelib-package-name-does-not-match usr/lib/x86_64-linux-gnu/girepository-1.0/GUPnPDLNAGst-2.0.typelib gir1.2-gupnpdlnagst-2.0 <- this one worth only an override IMHO + an explanation.
k (not done yet, pending on what to do with the other warning)
> Minor:
> - VCS could be updated in debian/control*
done in the Debian vcs already so stagged for the next upload
Do you want autopkgtest for that specific component or would be one for the gunpn stack enough?
Thanks for the review, some of the fixes are commited now, also some tweaks still needed before upload (see question bellow) /salsa. debian. org/gnome- team/gupnp- dlna/commit/ b161b805
https:/
> * -doc package: I think we should promote it as well in main ... If so, this dep should be fixed: Depends: lynx | www-browser
Done, changed to a Suggests: devhelp
> I think the build-dep on libgupnp-1.0-dev may thus be optional
Seems to be indeed, no difference without it, I removed it
> * debian/copyright has some missing copyright notices:
> Copyright: 2012-2013 Intel Corporation for instance in * as GPL-2.0+
Thanks, fixed now
> * 2 of the 4 lintian warning worth fixing IMHO: dlna-2. 0-dev: gir-missing- typelib- dependency usr/share/ gir-1.0/ GUPnPDLNAGst- 2.0.gir gir1.2- gupnpdlnagst- 2.0 -> dep from the -dev on the gir*
> W: libgupnp-
That's a bit tricky, there is no corresponding gir (which is the cause for the other lintian warning), they preferred to bundle the gir in the same binary and use a provide, in that context I don't think adding the depends makes sense? would you be ok with a lintian override?
> W: gir1.2- gupnpdlna- 2.0: typelib- package- name-does- not-match usr/lib/ x86_64- linux-gnu/ girepository- 1.0/GUPnPDLNAGs t-2.0.typelib gir1.2- gupnpdlnagst- 2.0 <- this one worth only an override IMHO + an explanation.
k (not done yet, pending on what to do with the other warning)
> Minor:
> - VCS could be updated in debian/control*
done in the Debian vcs already so stagged for the next upload
Do you want autopkgtest for that specific component or would be one for the gunpn stack enough?