Comment 5 for bug 31633

On Saturday 24 June 2006 22:25, David Sansome wrote:
> This has been fixed upstream.
>
> ** Changed in: gtk-qt-engine (Ubuntu)
> Status: Confirmed => Fix Committed

On Saturday 24 June 2006 22:24, you wrote:
> ------- Additional Comments From <email address hidden> 2006-06-24 14:24
> ------- This appears to be fixed in the latest version of the theme engine
> in CVS.
>
> Please reopen this bug if you still encounter problems after updating :)

Works here.... Kind of.

I've rebuild a package by applying the Ubuntu diff to CVS (sans Ubuntu patches
that are already in CVS).

It didn't build on a 64 bit machine, failing with the following error (sorry
about the wrapping):

if /bin/sh ../libtool --silent --tag=CXX --mode=compile
g++ -DHAVE_CONFIG_H -I. -I/home/martin/gtk-qt/gtk-qt-engine/./kcm_gtk -I.. -I/usr/include/kde -I/usr/share/qt3/include -I. -DQT_THREAD_SUPPORT -D_REENTRANT -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common -MT
kcmgtk.lo -MD -MP -MF ".deps/kcmgtk.Tpo" -c -o
kcmgtk.lo /home/martin/gtk-qt/gtk-qt-engine/./kcm_gtk/kcmgtk.cpp; \
        then mv -f ".deps/kcmgtk.Tpo" ".deps/kcmgtk.Plo"; else
rm -f ".deps/kcmgtk.Tpo"; exit 1; fi
/home/martin/gtk-qt/gtk-qt-engine/./kcm_gtk/kcmgtk.cpp:57: warning: unused
parameter 'name'
/home/martin/gtk-qt/gtk-qt-engine/./kcm_gtk/kcmgtk.cpp: In member
function 'void KcmGtk::firefoxFixClicked()':
/home/martin/gtk-qt/gtk-qt-engine/./kcm_gtk/kcmgtk.cpp:387: error: cast
from 'MozillaProfile*' to 'int' loses precision

I've managed to get it to build with the following fix (again, sorry about
wrapping):

--- ../cvs/gtk-qt-engine/kcm_gtk/kcmgtk.cpp 2006-06-24 19:04:28.000000000
+0100
+++ kcm_gtk/kcmgtk.cpp 2006-06-25 00:01:02.809634032 +0100
@@ -384,7 +384,7 @@
                        KListViewItem* i = new KListViewItem(w->profilesList);
                        i->setPixmap(0, icon);
                        i->setText(0, (p->type ? i18n("Thunderbird") :
i18n("Firefox")) + " - " + p->name);
- i->setText(1, QString::number((int)p));
+ i->setText(1, QString::number((Q_ULLONG)p));
                }

                dialog->setMainWidget(w);

I don't know if this is 'right', but I'm not that fussed since it just looks
like something for firefox, and I don't care if that breaks :)

Other than that, Emacs looks great - apart from the fact that emacs-unicode-2
doesn't build from CVS on 64 bit either!

Thanks very much,
Martin