Comment 32 for bug 723458

Revision history for this message
Søren Holm (sgh) wrote :

On the https://bugzilla.gnome.org/show_bug.cgi?id=643020 the following happenend,

---------------------------------------------------------------------------------------------------------------------------------------------------------------------
Wen Long FENG 2011-06-16 06:18:16 UTC
Per my understanding, it is a bug involved by gtk code change.
Per the documentation of gdk_window_shape_combine_region, setting shape_region
to NULL should make the gdkwindow be opaque. But under the new code, the
function will do nothing when set shape_region as NULL.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
Søren Holm [reporter] 2011-06-16 06:38:24 UTC
That is interresting news. I where just naive and trusted the commit message.
Thanks for that additional research. Maybe now the commit could be reverted?
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
Søren Holm [reporter] 2011-07-10 20:14:15 UTC
Is Wen Long Feng right about his thoughts? I can also see in the coe this :

 * If @shape_region is %NULL, the shape will be unset, so the whole
 * window will be opaque again. @offset_x and @offset_y are ignored
 * if @shape_region is %NULL.

So I guess he is right. Could someone please revert
208d717fefb7d1d1faa0dada132a290036b458d0 ?
---------------------------------------------------------------------------------------------------------------------------------------------------------------------

Apparently this is a bug in gtk. This tells me that we should all push to get commit 208d717fefb7d1d1faa0dada132a290036b458d0 reverted,