Comment 21 for bug 723458

Revision history for this message
Søren Holm (sgh) wrote :

Gytis, I it so great that you are here.

I do not have any proof, but given that the bad commit in gtk c282958fb4bb25c736c682735002d15c50cb44d0 realy just is an optimization, the usage of the affected funtion must be somewhat wrong - or at least missunderstood.

All other gtk-applications just as fine after as before the change. The change is quite small.

diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c
index c550aea..c4e8744 100644
--- a/gdk/gdkwindow.c
+++ b/gdk/gdkwindow.c
@@ -8640,6 +8640,9 @@ gdk_window_shape_combine_region (GdkWindow *window,
   if (GDK_WINDOW_DESTROYED (window))
     return;

+ if (!private->shaped && shape_region == NULL)
+ return;
+
   private->shaped = (shape_region != NULL);

   if (private->shape)