This is no longer applying the state when drawing the arrow, but that seems to
be correct, because I can't see that GtkComboBox passes its state to the style
context for gtk_render_arrow.
> if (!gComboBoxSeparatorWidget)
> return MOZ_GTK_SUCCESS;
>+ gtk_style_context_restore(style);
This save/restore is not balanced when taking the early return, but is
unnecessary anyway because the style context was not changed.
The save/restore for the style context of the gComboBoxSeparatorWidget is
similarly unnecessary.
Comment on attachment 595369
gtk drawing patch v.5
Thanks very much. combo_box_ paint:
Just a save/restore pair to remove in moz_gtk_
>- gtk_paint_ arrow(style, drawable, state_type, shadow_type, cliprect, idget, "arrow", GTK_ARROW_DOWN, TRUE, rect.width, real_arrow_ rect.height) ; get_style_ context( gComboBoxArrowW idget); context_ save(style) ; arrow(style, cr, ARROW_DOWN, rect.width) ;
>- gComboBoxArrowW
>- real_arrow_rect.x, real_arrow_rect.y,
>- real_arrow_
>-
>+ style = gtk_widget_
>+ gtk_style_
>+
>+ gtk_render_
>+ real_arrow_rect.x, real_arrow_rect.y,
>+ real_arrow_
This is no longer applying the state when drawing the arrow, but that seems to
be correct, because I can't see that GtkComboBox passes its state to the style
context for gtk_render_arrow.
> if (!gComboBoxSepa ratorWidget)
> return MOZ_GTK_SUCCESS;
>+ gtk_style_ context_ restore( style);
This save/restore is not balanced when taking the early return, but is
unnecessary anyway because the style context was not changed.
The save/restore for the style context of the gComboBoxSepara torWidget is
similarly unnecessary.