Comment 16 for bug 425650

Revision history for this message
Colin Watson (cjwatson) wrote :

Sorry, I think this patch is incorrect as it stands. The point of using grub-probe is to ensure that GRUB will be able to read it at boot time. 'test -r' would not achieve this - it would only check for file permissions, which are irrelevant here (we've already done 'test -e').

grub-probe should not take a long time, and if it is doing so then *that* is what should be fixed. That particular call is not in an inner loop or anything - indeed I think it's only called once per update-grub run, and there's no intrinsic reason it should be a bottleneck.