Comment 27 for bug 1103187

Revision history for this message
Péter Prőhle (prohlep) wrote : Re: xfs left inconcistent after reboot, causing grub to fail

http://oss.sgi.com/archives/xfs/2012-12/msg00324.html looks promising: "There is a logic inversion in xfssyncd_worker() which means that the log is not periodically forced or idled correctly. This means that metadata changes aggregated in memory do not get flushed in a timely manner, and hence if filesystem is not cleanly unmounted those changes can be lost. This loss can manifest itself even hours after the changes were made if the filesystem is left to idle without a sync() occurring between the last modification and the crash/shutdown occuring."

The kernel fix is only a negation of a condition in xfssyncd_worker() in fs/xfs/xfs_sync.c :

- if (!(mp->m_super->s_flags & MS_ACTIVE) &&

+ if ((mp->m_super->s_flags & MS_ACTIVE) &&

Dave Chinner (19 Dec 2012): "If people agree the fix is correct, I'll post it to the -stable list for inclusion..."

(1) I am ready to make experiment with the new fixed kernel. I compiled kernels in mid 90's, but I slowly gave up this habit at around 1988...2002. I think, it is worthwhile to check whether this fix solves the XFS/grub-install/reboot problem.

(2) How I will notice (or be noticed), when this patch arrives among the Ubuntu updates?