Comment 12 for bug 192590

Revision history for this message
Siegfried Gevatter (rainct) wrote :

There are some little problems with the patch:

- Please add "(LP: #192590)" (without the quotation marks) to the end of your changelog entry for this bug to be closed automatically.

- I might be wrong but it doesn't seem to me that your changelog entry is really related with the changes you did; perhaps you could improve it a bit to make it clearer.

- I didn't look at the source of the package but it seems to me that it is using a patch system (if you have "ubuntu-dev-tools" installed you can check if it really is using one and which one it running the command "what-patch" inside the package's source directory). If it is using one, please create a patch instead of just applying the changes directly to the source; you'll find instructions for all different patch system in the Packaging Guide (on the wiki).

- This package is in main, so you'll have to subscribe ubuntu-main-sponsors once you have a new debdiff ready (you can check in which component a package is with the command "apt-cache madison graphviz", replacing this last word with whatever package name you want).

Thanks for contributing to Ubuntu!