Comment 5 for bug 2064580
Revision history for this message
| Mauricio Faria de Oliveira (mfo) wrote | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
This bug received a prioritization request for SRU review.
Unfortunately, apparently the uploads for stable releases
haven't happened today so far (but I will check tomorrow).
Meanwhile, I have familiarized myself with the upload for
Oracular, which is expected to be quite similar to stable
releases (all releases will get the same version update);
and with the upstream changes (which closely match that).
AFAICT there is actually _very little_ changes to *code*
that have impacts to Ubuntu -- the bulk of changes (90%!)
are updates to the go version & vendorized dependencies.
Among the code changes, there is Windows and yum/zypper
(other package managers), all these don't affect Ubuntu.
(So, it's curious whether the actual needed changes may
be in the dep updates; otherwise, the code changes that
would be needed could be accomplished with simple patch
SRUs, as far as I can tell / if not missing something.)
Finally, considering that 90%+ of effective changes are
go deps, and that build-time tests seem to be few / not
cover it all, it is required to have plenty of testing
before releasing it for stable releases.
Notes:
-----
The upload in oracular-proposed; note it's quite big:
$ curl -sL 'https:/
$ cat oracular.debdiff | diffstat -s
572 files changed, 29195 insertions(+), 11535 deletions(-)
But the vendorized deps changes are literally 90% of it:
(91% of files changes, 92% of insertions, 90% of deletions)
$ cat oracular.debdiff | filterdiff -i '*/debian/
519 files changed, 26866 insertions(+), 10356 deletions(-)
@ debian/rules:
9 override_
10 cp -r debian/extra/vendor ./
11 dh_auto_configure
...
24 override_dh_clean:
25 dh_clean vendor/
Plus e2e_tests which are not built/tested/
(4.2% of files changed, 6.3% of insertions, 2.9% of deletions)
@ debian/rules:
3 export DH_GOLANG_EXCLUDES := e2e_tests
$ cat oracular.debdiff | filterdiff -i '*/e2e_tests/*' | diffstat -s
14 files changed, 1179 insertions(+), 277 deletions(-)
$ cat oracular.debdiff | filterdiff -i '*/examples/*' | diffstat -s
10 files changed, 674 insertions(+), 10 deletions(-)
That is, approximately 95%/98%/93% of the modifications, in total.
Looking at what is left:
(5% of files changes, 1.6% of insertions, 7.7% of deletions)
$ cat oracular.debdiff | filterdiff -x '*/debian/
29 files changed, 476 insertions(+), 892 deletions(-)
Taking out a few other files that are not code changes either
(e.g., build-time tests, upstream docs, and changelog/series),
the list is quite small:
$ cat oracular.debdiff | filterdiff -x '*/debian/
-x '*/*_test.go' -x '*/OWNERS' -x '*/README.md' -x '*/debian/
agentconfig/
agentendpoint
attributes/
clog/clog.go | 18 +-
config/
config/
debian/
go.mod | 43 +++++-
go.sum | 806 ++++---
main.go | 2
main_linux.go | 2
main_windows.go | 4
ospatch/
packages/
packages/yum.go | 6
packages/
policies/apt.go | 40 ++++--
policies/
util/
util/util.go | 12 -
20 files changed, 241 insertions(+), 878 deletions(-)
Reviewing that with this:
$ cat oracular.debdiff | filterdiff ... | vim -
The actual code changes are simple, and originate from just 9 commits upstream.
These commits are mostly non-Ubuntu related stuff (Windows Updates, yum (RedHat), zypper (SUSE)).
But there are *many* go modules/deps updated, including go version changes.
The commits can be found in the diff range of the requested version update:
https:/
Commits:
Call fqdn (#481)
https:/
Fix condition to have 10 attempts rather than 11. (#477)
https:/
Migrate empty interface to any (#483)
https:/
No functional change
For convenience, the predeclared type any is an alias for the empty interface. [Go 1.18]
https:/
GuestPolicies e2e: Remove ed package if exist for zypper startup_script in recipe-steps tests (#532)
https:/
Enable OSConfig agent to read GPG keys files with multiple entities (#537)
https:/
Perhaps disabled at build time via patch
0001-
Added SCODE to Windows error description (#504)
https:/
Fix parse yum updates to consider the packages under installing-
https:/
Change debug messages when parsing zypper patch output (#490)
https:/
Fix zypper patch info parser to consider conflicts-pkgs float versions (#528)
https:/
This one seems to be the only which effectively addresses Ubuntu behavior:
Enable OSConfig agent to read GPG keys files with multiple entities (#537)
go version changes:
244 diff -Nru google-
250 -go 1.16
251 +go 1.21
https:/
Update go version in go.mod (#479)
1.16 -> 1.17
Migrate empty interface to any (#483)
https:/
1.17 -> 1.19
https:/
Update go version to 1.21 (#507)
(empty, apparently a mistake; actually applied in 'Call fqdn (#481)'
1.19 -> 1.21
go version/mod deps updates in go.mod and go.sum
Worth noting:
Remove tests for Ubuntu 18.04 (EOL) (#476)
https:/
Should we revert that, as an SRU to Bionic/18.04 is being requested?
Now, comparing the code-only diff above from Oracular, with the GitHub commit range for the 2 versions:
It's the same; the only difference is the patch to disable test(s) at runtime (avoid internet download),
which accounts for the missing 21 lines difference between '220/241 insertions'):
'd/p/0001-
$ curl -sL 'https:/
$ cat github.diff | filterdiff -x '*/debian/
-x '*/*_test.go' -x '*/OWNERS' -x '*/README.md' -x '*/debian/
agentconfig/
agentendpoint
attributes/
clog/clog.go | 18 +--
config/
config/
go.mod | 43 ++++++--
go.sum | 806 ++++---
main.go | 2
main_linux.go | 2
main_windows.go | 4
ospatch/
packages/
packages/yum.go | 6 -
packages/
policies/apt.go | 40 ++++---
policies/
util/
util/util.go | 12 +-
19 files changed, 220 insertions(+), 878 deletions(-)