Thanks for the review! Part of the reason that this package is a bit
confusing is that it is only building a small part of the source it
includes. I added a debian/README.Debian file explaining what is going
on:
======================================================
Runtime support for Go's race detector
--------------------------------------
This package follows the instructions in the Go source:
that describe how to build the race detector runtime support from
source. The race detector depends on runtime support from the
"compiler-rt" runtime libraries (http://compiler-rt.llvm.org/),
specifically the ThreadSanitizer (aka "tsan") library. The Go source
distribution includes this support as a built object file which
obviously violates the principle of knowing that the binaries are
actually produced from the source they claim to be, hence this
package.
The compiler-rt source is included in other source packages (at least
gcc and llvm-toolchain) but I created one specifically for this task
so that we can use the same revision of the compiler-rt source as the
currently packaged version of Go.
This does mean that building this package only uses a relatively small
part of the source that it distributes -- for example, it doesn't
execute the full testsuite, just the small part that is run by the
buildgo.sh script.
======================================================
Do things make a bit more sense now?
On 18 September 2015 at 17:52, Martin Pitt <email address hidden> wrote:
> Packaging review:
> - Please use 3.0 (quilt) source format for clean and standard patch management.
I thought I had done that but indeed not. Fixed.
> - Disabling "make check" (override_dh_auto_test) is a bit sad -- when
> running "make check" it fails with "unable to infer compiler target
> triple for clang". Is there any way to run the tests with gcc? If not,
> should this get a clang build dependency? If that doesn't work, please
> add a comment to debian/rules why tests can't/shouldn't be run.
I hope README.Debian explains this now?
> - W: go-race-detector-runtime source: dep5-copyright-license-name-not-unique (paragraph at line 35)
I don't get this warning, is it new in wily?
> Indeed you used "License: Expat" with two different license texts, AFAICS mostly due to including the copyright into it (which shouldn't happen -- that's what Copyright: is for). It's usually best to just say "License: Expat" in all Files: stanzas, and have a separate
>
> License: expat
> ..blabla long text
>
> stanza at the bottom, to avoid repetition.
OK, updated that.
> - There are several missing copyrights in debian/copyright, e. g.
> ./lib/BlocksRuntime/Block.h has "Copyright 2008-2010 Apple, Inc."
Well I went looking and found that and one other (cpplint.py which is
(c) google). Is there a way to be sure you've got them all? (I grep
-riF for "(c)" and "copyright").
Thanks for the review! Part of the reason that this package is a bit README. Debian file explaining what is going
confusing is that it is only building a small part of the source it
includes. I added a debian/
on:
======= ======= ======= ======= ======= ======= ======= ===== ------- ------- ------- ------- ---
Runtime support for Go's race detector
-------
This package follows the instructions in the Go source:
https:/ /go.googlesourc e.com/go/ +/master/ src/runtime/ race/README
that describe how to build the race detector runtime support from compiler- rt.llvm. org/),
source. The race detector depends on runtime support from the
"compiler-rt" runtime libraries (http://
specifically the ThreadSanitizer (aka "tsan") library. The Go source
distribution includes this support as a built object file which
obviously violates the principle of knowing that the binaries are
actually produced from the source they claim to be, hence this
package.
The compiler-rt source is included in other source packages (at least
gcc and llvm-toolchain) but I created one specifically for this task
so that we can use the same revision of the compiler-rt source as the
currently packaged version of Go.
This does mean that building this package only uses a relatively small ======= ======= ======= ======= ======= ======= =====
part of the source that it distributes -- for example, it doesn't
execute the full testsuite, just the small part that is run by the
buildgo.sh script.
=======
Do things make a bit more sense now?
On 18 September 2015 at 17:52, Martin Pitt <email address hidden> wrote:
> Packaging review:
> - Please use 3.0 (quilt) source format for clean and standard patch management.
I thought I had done that but indeed not. Fixed.
> - Disabling "make check" (override_ dh_auto_ test) is a bit sad -- when
> running "make check" it fails with "unable to infer compiler target
> triple for clang". Is there any way to run the tests with gcc? If not,
> should this get a clang build dependency? If that doesn't work, please
> add a comment to debian/rules why tests can't/shouldn't be run.
I hope README.Debian explains this now?
> - W: go-race- detector- runtime source: dep5-copyright- license- name-not- unique (paragraph at line 35)
I don't get this warning, is it new in wily?
> Indeed you used "License: Expat" with two different license texts, AFAICS mostly due to including the copyright into it (which shouldn't happen -- that's what Copyright: is for). It's usually best to just say "License: Expat" in all Files: stanzas, and have a separate
>
> License: expat
> ..blabla long text
>
> stanza at the bottom, to avoid repetition.
OK, updated that.
> - There are several missing copyrights in debian/copyright, e. g. time/Block. h has "Copyright 2008-2010 Apple, Inc."
> ./lib/BlocksRun
Well I went looking and found that and one other (cpplint.py which is
(c) google). Is there a way to be sure you've got them all? (I grep
-riF for "(c)" and "copyright").
> and the license is BSD.
Nope, still Expat :-) (verified with wdiff)
Uploaded a new package, please take another look.