gnome-terminal has no ability to disable close button on tabs

[Alexander Butenko]

Binary package hint: gnome-terminal

gnome-terminal has a close button on each tab. This is the cause of a big height of tabs.
My patch is adding a gconf entry which will allow to disable close button on tabs.

[Alexander Butenko (avb)]

patch 1

[Alexander Butenko (avb)]

patch 2

[Sebastien Bacher (seb128)]

Thank you for your bug. There is a bug upstream: http://bugzilla.gnome.org/show_bug.cgi?id=335453, could you comment on it with your change?

[Alexander Butenko (avb)]

yes, i add few comments with attached patch. Thanks for the help. Lets see how it will be.

The better thing for a whole gnome environment is a global variable in gtkrc which will handle to process of displaying close buttons on tabs. I was a bit surprised about a fact that GtkNotebook has no builtin abbility to make close buttons or tab icons itself. And thats why all applications which use GtkNotebook have different implementations of tabs behavoir.

Maybe lets fill a feature request in gtk+ bugzilla to add such functional into a gtknotebook implementation?

[Sebastien Bacher (seb128)]

the upstream bug can be changed to GTK+ if required

[Alexander Butenko (avb)]

Sebastien, this problem is discussion for a long time in gnome bugzilla and there is no steps made to solve the problem.
I have tested patch on 10 machines in both enabled and disabled states.
Maybe its possible to include my patch into ubuntu gnome-terminal package? I will provide it for each release of gnome-terminal.

[Sebastien Bacher (seb128)]

I would prefer to have that patch accept upstream which is the right place for it

[Alexander Butenko (avb)]

gnome guys dont like this idea, so i think we can close bug here. thanks for your hard work.

[Daniel Hahler (blueyed)]

Alexander, can you update your patch at the Gnome bug report?
From skimming through the comments, it might get considered, but does not apply (mainly probably due to not using "-u").

[Alexander Butenko (avb)]

code was changed a lot.
here is updated patches

[Daniel Hahler (blueyed)]

Thanks a lot, Alexander.

Can you please attach it to the upstream bug - since it make sense for Ubuntu only to get it from there/upstream (see previous comments).

I don't know, but if it's possible, please make a single patch against the Gnome source, instead of two separate patches.