Ubuntu
gnome-terminal package

  1. Bug #1451924
  2. Comment #30

Comment 30 for bug 1451924

Revision history for this message
In , Rishi-is (rishi-is) wrote :

(In reply to Matthias Clasen from comment #9)
> Review of attachment 298001 [details] [review]:
> ::: src/terminal-screen-container.c
> @@ +107,3 @@
> + GTK_POLICY_NEVER,
> + GTK_POLICY_ALWAYS);
> + gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));
>
> it would be more idiomatic to say
>
> gtk_scrolled_window_new (NULL, NULL);
> gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));
>
> and have the two deal with their adjustments internally...

Passing NULL and letting GtkScrolledWindow create a new GtkAdjustment and pass it to VteTerminal is not working the same way as getting the GtkAdjustment out of VteTerminal and giving it to GtkScrolledWindow. A brief investigation suggests that the page-increment is different, which causes it to scroll by 1 line instead of page-increment/10 lines when using the mouse's scroll wheel.

One could say that it is a bug in the GtkScrollable implementation. For the purposes of this bug, let's keep doing what the old has been doing so far. ie. the latter option.