Comment 19 for bug 1451924

Revision history for this message
In , Rishi-is (rishi-is) wrote :

(In reply to Christian Persch from comment #13)
> Actually testing the patch reveals several problems:
>
> * Lots of warnings on console: (gnome-terminal-server:16272): Gtk-WARNING
> **: Toplevel size doesn't seem to directly depend on the size of the
> geometry widget from gtk_window_set_geometry_hints(). The geometry widget
> might not be in the window, or it might not be packed into the window
> appropriately
>
> * Creating tabs and switching between them shrinks the window
>
> * Even just running 'ls' at the prompt shrinks the window

Oops, sorry. I did not test it with tabs. I thought we fixed the shrinking issue in bug 743395 , but apparently not.

> I guess the above are all due to the warning.

Possibly. They don't look as harmless as I assumed them to be. I will take a look.

> * Checking "Show scrollbar" in prefs doesn't work anymore: there is no
> scrollbar visible while not moving the mouse; when moving the mouse over the
> terminal but outside the scrollbar area, a thick rounded rectangle shows up,
> which only turns into a (transparent, ugh) scrollbar when the mouse if over
> it.
>
> * The scrollbar is now transparent on top of the content, instead of
> intransparent and beside the content, as it should be. This means that
> (depending on font size), it's impossible to start selecting in the last 1-2
> char cells of each row. Filed as bug .
>
> I think both of these can be fixed by setting the overlay-scrolling property
> to FALSE, which we should therefore do.

How about adding an option in preferences to toggle the overlay-scrolling ?