Ubuntu
gnome-terminal package

  1. Bug #1451924
  2. Comment #10

Comment 10 for bug 1451924

Revision history for this message
In , Matthias Clasen (mclasen) wrote :

Review of attachment 298001:

Looks good to me, otherwise. Great that the EXTERNAL policy found an actual use case!

::: src/terminal-screen-container.c
@@ +107,3 @@
+ GTK_POLICY_NEVER,
+ GTK_POLICY_ALWAYS);
+ gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));

it would be more idiomatic to say

gtk_scrolled_window_new (NULL, NULL);
gtk_container_add (GTK_CONTAINER (priv->sw), GTK_WIDGET (priv->screen));

and have the two deal with their adjustments internally...