Comment 57 for bug 968213

Revision history for this message
In , Pierre-bugzilla (pierre-bugzilla) wrote :

I'm trying to get the proposed design to work, but it is difficult for three reasons:

 - There is no value provided for suitable padding. Currently the padding is simply what's left after the icon and label have taken their areas, so there is no need to specify it.

 - I can't get the allocation code to behave properly. It will never allocate more than the minimum height needed, even if there is room. It seems like _getPreferredHeight()/_getPreferredWidth() is never called with anything except -1 as the argument.

 - Icon boxes tend to become rectangular, causing the "running" indicator to either have an offset from the bottom, or not be wide enough.

Is the proposed design a hard requirement? Or can forced square containers with varying amounts of padding be acceptable for now? I'd really like to see these changes get in 3.4.