Comment 5 for bug 1838152

Revision history for this message
Robie Basak (racb) wrote :

I'm not sure this fix is complete. What about, for example: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/19e084036a1dc3c5da010c3e7a42ce67df317797? As far as I understand, it is exactly (and only) the fsync() call that we're trying to move off the main thread, and this commit suggests to me that the fix proposed in this SRU won't actually do that.

Please could you take a look, and also for anything else relevant in upstream's branches? We risk regression every time we land an SRU, so if this commit or others need to go in also, then it'd be better for us to SRU a fix for this only once.