"Open in Terminal" returns "Text ended before matching quote was found for '"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gnome-shell-extension-desktop-icons |
Fix Released
|
Unknown
|
|||
gnome-shell-extension-desktop-icons (Ubuntu) |
Fix Released
|
High
|
Iain Lane | ||
Disco |
Fix Released
|
High
|
Iain Lane |
Bug Description
[ Description ]
Attempting to open a Desktop folder named "aaa'bbb" (without double quotes) using the "Open in Terminal" option from the context menu produces a notification message stating:
Execution of "x-terminal-
Text ended before matching quote was found for '. (The text was "x-terminal-
This suggests improper escaping (possible security impact with command injection).
[ QA ]
Steps to reproduce:
1. On the Ubuntu 19.04.0 amd64 Desktop, right-click, and select "New folder"
2. Enter the following folder name and press Enter: aaa'bbb
3. Right-click on the newly created folder icon
4. Select "Open in Terminal"
5. The above notification pops up, no terminal window opens.
The expected outcome would be:
5. A terminal window opens in directory ~/Desktop/aaa'bbb
[ Regression potential ]
See bug #1829244
[ ... ]
ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: gnome-shell-
ProcVersionSign
Uname: Linux 5.0.0-13-generic x86_64
ApportVersion: 2.20.10-0ubuntu27
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Thu Apr 18 18:40:28 2019
InstallationDate: Installed on 2019-04-14 (4 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Alpha amd64 (20190413.2)
PackageArchitec
SourcePackage: gnome-shell-
UpgradeStatus: No upgrade log present (probably fresh install)
information type: | Public → Public Security |
Changed in gnome-shell-extension-desktop-icons: | |
status: | Unknown → New |
Changed in gnome-shell-extension-desktop-icons: | |
status: | New → Fix Released |
Changed in gnome-shell-extension-desktop-icons (Ubuntu Disco): | |
importance: | Undecided → High |
Marking this as security since the following directory name proves command execution is possible:
aaa -e bash -c 'firefox'