"Open in Terminal" returns "Text ended before matching quote was found for '"

[Tom Reynolds]

[ Description ]

Attempting to open a Desktop folder named "aaa'bbb" (without double quotes) using the "Open in Terminal" option from the context menu produces a notification message stating:

Execution of "x-terminal-emulator --working-directory=/home/...
Text ended before matching quote was found for '. (The text was "x-terminal-emulator --working-directory=/home/x/Desktop/aaa'bbb")

This suggests improper escaping (possible security impact with command injection).

[ QA ]

Steps to reproduce:

1. On the Ubuntu 19.04.0 amd64 Desktop, right-click, and select "New folder"
2. Enter the following folder name and press Enter: aaa'bbb
3. Right-click on the newly created folder icon
4. Select "Open in Terminal"
5. The above notification pops up, no terminal window opens.

The expected outcome would be:
5. A terminal window opens in directory ~/Desktop/aaa'bbb

[ Regression potential ]

See bug #1829244

[ ... ]

ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: gnome-shell-extension-desktop-icons 19.01.1-1
ProcVersionSignature: Ubuntu 5.0.0-13.14-generic 5.0.6
Uname: Linux 5.0.0-13-generic x86_64
ApportVersion: 2.20.10-0ubuntu27
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Thu Apr 18 18:40:28 2019
InstallationDate: Installed on 2019-04-14 (4 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Alpha amd64 (20190413.2)
PackageArchitecture: all
SourcePackage: gnome-shell-extension-desktop-icons
UpgradeStatus: No upgrade log present (probably fresh install)

[Mike Salvatore (mikesalvatore)]

Marking this as security since the following directory name proves command execution is possible:

aaa -e bash -c 'firefox'

[Tom Reynolds (tomreyn)]

As discussed on IRC, command injection is actually possible here.

[Sebastien Bacher (seb128)]

Iain, could you have a look to this one?

[Mike Salvatore (mikesalvatore)]

Upstream bug: https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/issues/111

[Iain Lane (laney)]

I've pinged upstream, expecting a release soon which I will try to SRU.

[Iain Lane (laney)]

OK got it in eoan, will update disco now (might take some time to be processed).

[Brian Murray (brian-murray)]

Hello Tom, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/19.01.3-1~ubuntu19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Tom Reynolds (tomreyn)]

I tested version 19.01.3-1~ubuntu19.04.1 (from -proposed) on a fully updated 19.04, and can no longer reproduce this issue: The terminal window opens - as expected - in directory ~/Desktop/aaa'bbb/. Injecting commands as discussed in comment 2 appears to be no longer possible.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons - 19.01.3-1~ubuntu19.04.1

---------------
gnome-shell-extension-desktop-icons (19.01.3-1~ubuntu19.04.1) disco; urgency=medium

  * Backport new upstream release from eoan to disco (LP: #1829244)
    - Fixes insecure commandline construction problem (LP: #1825396)

gnome-shell-extension-desktop-icons (19.01.3-1) experimental; urgency=medium

  * New upstream release
  * Drop all patches, since they are included upstream

 -- Iain Lane <email address hidden> Wed, 15 May 2019 15:13:51 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-shell-extension-desktop-icons has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.