Using DiNG triggers ubuntu-dock opacity

[Coeur Noir]

Hi,

Ubuntu 22.04 LTS
jammy
Linux 5.15.0-40-generic x86_64 x86_64
ubuntu-xorg / x11

I prefer panel and dock to become fully opaque only when windows are maximized.

So I use this extension for panel : Transparent Top Bar (Adjustable transparency) which JustWorks™ in both Xorg and Wayland.

In ubuntu-dock, dynamic-transparency is set through dconf-editor ( transparency-mode, min-alpha, max-alpha. )

When using DiNG under Wayland, opacity is triggered as if « desktop » was considered as a maximized window.

Under Xorg, DiNG does not trigger dock opacity, as expected.

[Daniel van Vugt (vanvugt)]

DING became a maximized window in Wayland sessions since the most recent update to fix bug 1976204.

I suggest the fix here is for "Transparent Top Bar" to ignore the DING window once it has 'hide_from_window_list' set.

[Coeur Noir (coeur-noir)]

Hi and thanks for answer.

Sorry for my low understanding but what am I supposed to do with your suggestion ?

Is there a way to tell ubuntu-dock ( when used in Wayland ) to ignore the DiNG maximized window ?

Hence the « won't fix » ? It's not a bug but a matter of ubuntu-dock settings ?

[Daniel van Vugt (vanvugt)]

I was suggesting that you probably need to log a bug against the "Transparent Top Bar" extension. But my previous comments were a little wrong...

It looks like "Transparent Top Bar" needs to be modified to check the "window.skip_taskbar" flag and ignore any windows with that set. Then it won't get fooled by DING technically being a maximized window.

[Coeur Noir (coeur-noir)]

Guess you already know about :

Add compatibility with DING for Dynamic Transparency #1767
https://github.com/micheleg/dash-to-dock/pull/1767

[Daniel van Vugt (vanvugt)]

I did not, but indeed that sounds like the right fix for dash-to-dock and ubuntu-dock. I've added a task tracking the bug in ubuntu-dock here.

[Daniel van Vugt (vanvugt)]

Please test:

  https://github.com/micheleg/dash-to-dock/pull/1767.patch

If it works for you then I will get it merged upstream.

[Coeur Noir (coeur-noir)]

And now I feel utterly ashamed and useless because I don't know how to test that.

[Gunnar Hjalmarsson (gunnarhj)]

One way is to just download it and:

sudo patch /<email address hidden>/theming.js ~/Downloads/1767.patch

[Coeur Noir (coeur-noir)]

^^

Thanks ! Aaaand… it works I can now use Wayland and having Dynamic Transparency for both Ubuntu Dock ( and top panel ).

[Daniel van Vugt (vanvugt)]

Fix committed to the next ubuntu-dock release (no ETA):

https://github.com/micheleg/dash-to-dock/commit/e0c26e996d44127b96a94f28dab0e6b5e6550e0e

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72ubuntu2

---------------
gnome-shell-extension-ubuntu-dock (72ubuntu2) kinetic; urgency=medium

  [ Patryk Skorupa ]
  * Add compatibility with DING for Dynamic Transparency (LP: #1981837)

  [ Daniel van Vugt ]
  * Declare compatibility with gnome-shell 43 (LP: #1987272)

 -- Daniel van Vugt <email address hidden> Mon, 22 Aug 2022 17:37:30 +0800

[Coeur Noir (coeur-noir)]

Hi,

am very surprised, as I am facing the same behaviour on a freshly installed Ubuntu 22.04 LTS :

on Wayland, using DING triggers opacity in ubuntu-dock with dynamic-transparency,

it's okay on Xorg.

[Coeur Noir (coeur-noir)]

Forget to mention :

gnome-shell-extension-ubuntu-dock is 72~ubuntu5.22.04.1
and
gnome-shell-extension-desktop-icons-ng is 43-2ubuntu1

( If of any interest, dash-to-panel and transparent-top-bar gnome-shell-extensions don't have their opacity triggered by DiNG, they behave as expected on both Wayland and Xorg. )

[Coeur Noir (coeur-noir)]

It has been fixed a moment and now it's back… 22.04 LTS

gnome-shell-extension-ubuntu-dock 72~ubuntu5.22.04.2.1

[Coeur Noir (coeur-noir)]

See https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/+bug/2023916

[Daniel van Vugt (vanvugt)]

This bug was never fixed in 22.04. Only in 22.10 and later.

[Daniel van Vugt (vanvugt)]

Just added a reminder to fix this in jammy, some time.

[Coeur Noir (coeur-noir)]

…aah ok, I thought it was fixed in priority in LTS, my bad.

Applying the 1767.patch from #6 still fixes the issue ;-)

[Coeur Noir (coeur-noir)]

« Just added a reminder to fix this in jammy, some time. »

Is it ?