Comment 0 for bug 1896785

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

[ Impact ]

GNOME shell when using this indicator should export the org.kde.StatusNotifierWatcher dbus interface, although some methods and properties are missing or invalid

[ Test case ]

Run:
 gdbus call --session --dest org.gnome.Shell --object-path /StatusNotifierWatcher \
 --method org.freedesktop.DBus.Properties.Get "org.kde.StatusNotifierWatcher" ProtocolVersion

-> Should return (<0>,)

In particular, the API should contain

 gdbus introspect --session --dest org.gnome.Shell --object-path /StatusNotifierWatcher
node /StatusNotifierWatcher {

  .... Default fdo properties stuff ....

  interface org.kde.StatusNotifierWatcher {
    interface org.kde.StatusNotifierWatcher {
    methods:
      RegisterStatusNotifierItem(in s service);
      RegisterStatusNotifierHost(in s service);
    signals:
      StatusNotifierItemRegistered(s arg_0);
      StatusNotifierItemUnregistered(s arg_0);
      StatusNotifierHostRegistered();
      StatusNotifierHostUnregistered();
    properties:
      @org.qtproject.QtDBus.QtTypeName.Out0("QStringList")
      readonly as RegisteredStatusNotifierItems = [ ... list of indicators path/obj-names ... ];
      readonly b IsStatusNotifierHostRegistered = true;
      readonly i ProtocolVersion = 0;
  };
};

In the old version we had an invalid "RegisterNotificationHost" method (not specified by specs nor used)
We didn't expose the ProtocolVersion