Comment 20 for bug 1248368

Revision history for this message
Russell King (rmk+ubuntu) wrote :

There are other problems with that patch:

@@-1327,8 +1430,12 @@
                        g_object_unref (manager->priv->stream);
                        manager->priv->stream = NULL;
                }
+ if (gvc_mixer_stream_get_id (manager->priv->input_stream)
+ == id) {
+ g_object_unref (manager->priv->input_stream);
+ manager->priv->input_stream = NULL;
+ }

The if() block which encloses all this code checks that manager->priv->stream is non-NULL. Nothing checks that manager->priv->input_stream is non-NULL before passing it to gvc_mixer_stream_get_id()... and this results in... "** (gnome-settings-daemon:32266): CRITICAL **: gvc_mixer_stream_get_id: assertion `GVC_IS_MIXER_STREAM (stream)' failed"