| 2011-02-24 13:59:02 |
Alex Murray |
bug |
|
|
added bug |
| 2011-02-24 13:59:02 |
Alex Murray |
attachment added |
|
Patch to implement keyboard backlight support in g-p-m 2.32 for natty https://bugs.launchpad.net/bugs/724324/+attachment/1868852/+files/99-keyboard-backlight-support.patch |
|
| 2011-02-24 14:01:25 |
Alex Murray |
tags |
|
patch |
|
| 2011-02-24 14:24:20 |
Chris Coulson |
gnome-power-manager (Ubuntu): importance |
Undecided |
Wishlist |
|
| 2011-02-24 14:24:20 |
Chris Coulson |
gnome-power-manager (Ubuntu): status |
New |
Incomplete |
|
| 2011-02-24 17:35:13 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2011-02-27 11:33:38 |
Alex Murray |
summary |
g-p-m should add support for controlling keyboard backlight via upower in natty |
FFE: Add support to g-p-m for controlling keyboard backlight via upower in natty |
|
| 2011-02-27 11:57:16 |
Alex Murray |
description |
Binary package hint: gnome-power-manager
upower 0.9.8 supports controlling keyboard backlights and exposes an appropriate dbus interface to control them.
g-p-m can simply access this to control keyboard backlights in much the same way as it does for lcd / display backlights.
Attached is a patch to implement such support - this is against g-p-m in maverick but should apply pretty cleanly for natty since we are still using the same version. |
Binary package hint: gnome-power-manager
The version of upower (0.9.8) in Natty now has support for controlling keyboard backlights via dbus, and upstream g-p-m git HEAD (soon to be released 3.0 for GNOME 3) just added support for controlling these, however the version of g-p-m shipped in Natty (2.32) does not have any such support.
Keyboard backlight support was previously available via HAL in Hardy but was then removed when the dehalsification started and no such support has been available since, and as such adding support to g-p-m in Natty is (and has been for a while) greatly needed.
I have written a patch against g-p-m 2.32 which provides such support and is similar to the support recently added to g-p-m 3.0.
This patch adds a new GpmBacklightKbd object to g-p-m (which is based on the existing GpmBacklight object which controls the LCD backlight) to control the UPower KbdBacklight DBus interface and the patch provides support for:
* controlling the backlight via the appropriate backlight up / down buttons
* automatically dimming the backlight on idle when the lcd is dimmed
* automatically shutting of the keyboard backlight when the lcd is shut off
* displaying the keyboard brightness level via notify-osd (like we do for lcd backlight level) when changed by the user
I have tested this patch significantly myself over numerous days with no issues. After a quick post on the ubuntuforums (http://ubuntuforums.org/showthread.php?t=1694678) at least one other user has also confirmed this patch as working well and providing a reasonable improvement over current sub-optimum methods of controlling the keyboard backlight (such as using pommed, which is only available for MacBook machines and does not support other laptops with keyboard backlights such as various Asus models, which the upower + g-p-m method does).
I am requesting a FFE to merge the attached patch into g-p-m in Natty to provide such support.
A build log for g-p-m 2.32 in Maverick using the attached patch is available my ppa (amd64 version https://launchpad.net/~alexmurray/+archive/ppa/+buildjob/2283751/+files/buildlog_ubuntu-maverick-amd64.gnome-power-manager_2.32.0-0ubuntu2_BUILDING.txt.gz).
I am currently installing a natty daily vm to test building of the Natty version of g-p-m 2.32 with this patch, but due to the almost identical nature of g-p-m in Natty and Maverick I do not expect any problems. |
|
| 2011-02-27 23:21:01 |
Alex Murray |
description |
Binary package hint: gnome-power-manager
The version of upower (0.9.8) in Natty now has support for controlling keyboard backlights via dbus, and upstream g-p-m git HEAD (soon to be released 3.0 for GNOME 3) just added support for controlling these, however the version of g-p-m shipped in Natty (2.32) does not have any such support.
Keyboard backlight support was previously available via HAL in Hardy but was then removed when the dehalsification started and no such support has been available since, and as such adding support to g-p-m in Natty is (and has been for a while) greatly needed.
I have written a patch against g-p-m 2.32 which provides such support and is similar to the support recently added to g-p-m 3.0.
This patch adds a new GpmBacklightKbd object to g-p-m (which is based on the existing GpmBacklight object which controls the LCD backlight) to control the UPower KbdBacklight DBus interface and the patch provides support for:
* controlling the backlight via the appropriate backlight up / down buttons
* automatically dimming the backlight on idle when the lcd is dimmed
* automatically shutting of the keyboard backlight when the lcd is shut off
* displaying the keyboard brightness level via notify-osd (like we do for lcd backlight level) when changed by the user
I have tested this patch significantly myself over numerous days with no issues. After a quick post on the ubuntuforums (http://ubuntuforums.org/showthread.php?t=1694678) at least one other user has also confirmed this patch as working well and providing a reasonable improvement over current sub-optimum methods of controlling the keyboard backlight (such as using pommed, which is only available for MacBook machines and does not support other laptops with keyboard backlights such as various Asus models, which the upower + g-p-m method does).
I am requesting a FFE to merge the attached patch into g-p-m in Natty to provide such support.
A build log for g-p-m 2.32 in Maverick using the attached patch is available my ppa (amd64 version https://launchpad.net/~alexmurray/+archive/ppa/+buildjob/2283751/+files/buildlog_ubuntu-maverick-amd64.gnome-power-manager_2.32.0-0ubuntu2_BUILDING.txt.gz).
I am currently installing a natty daily vm to test building of the Natty version of g-p-m 2.32 with this patch, but due to the almost identical nature of g-p-m in Natty and Maverick I do not expect any problems. |
Binary package hint: gnome-power-manager
The version of upower (0.9.8) in Natty now has support for controlling keyboard backlights via dbus, and upstream g-p-m git HEAD (soon to be released 3.0 for GNOME 3) just added support for controlling these, however the version of g-p-m shipped in Natty (2.32) does not have any such support.
Keyboard backlight support was previously available via HAL in Hardy but was then removed when the dehalsification started and no such support has been available since, and as such adding support to g-p-m in Natty is (and has been for a while) greatly needed.
I have written a patch against g-p-m 2.32 which provides such support and is similar to the support recently added to g-p-m 3.0.
This patch adds a new GpmBacklightKbd object to g-p-m (which is based on the existing GpmBacklight object which controls the LCD backlight) to control the UPower KbdBacklight DBus interface and the patch provides support for:
* controlling the backlight via the appropriate backlight up / down buttons
* automatically dimming the backlight on idle when the lcd is dimmed
* automatically shutting of the keyboard backlight when the lcd is shut off
* displaying the keyboard brightness level via notify-osd (like we do for lcd backlight level) when changed by the user
I have tested this patch significantly myself over numerous days with no issues. After a quick post on the ubuntuforums (http://ubuntuforums.org/showthread.php?t=1694678) at least one other user has also confirmed this patch as working well and providing a reasonable improvement over current sub-optimum methods of controlling the keyboard backlight (such as using pommed, which is only available for MacBook machines and does not support other laptops with keyboard backlights such as various Asus models, which the upower + g-p-m method does).
I am requesting a FFE to merge the attached patch into g-p-m in Natty to provide such support.
A build log for g-p-m 2.32 in Natty using the attached patch is available my ppa (http://launchpadlibrarian.net/65256989/buildlog_ubuntu-natty-i386.gnome-power-manager_2.32.0-2ubuntu2_BUILDING.txt.gz). |
|
| 2011-02-27 23:56:13 |
Chris Coulson |
bug |
|
|
added subscriber Ubuntu Release Team |
| 2011-02-27 23:56:32 |
Chris Coulson |
gnome-power-manager (Ubuntu): status |
Incomplete |
New |
|
| 2011-02-28 07:35:08 |
Martin Pitt |
gnome-power-manager (Ubuntu): status |
New |
Confirmed |
|
| 2011-03-15 01:05:48 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-desktop/gnome-power/ubuntu |
|
| 2011-03-15 01:08:13 |
Chris Coulson |
gnome-power-manager (Ubuntu): status |
Confirmed |
Fix Committed |
|
| 2011-03-15 01:10:17 |
Launchpad Janitor |
gnome-power-manager (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2011-03-15 23:31:16 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/gnome-power-manager |
|
