Comment 9 for bug 285815

Revision history for this message
Alex Murray (alexmurray) wrote :

I guess we need to first get the values which the light sensor reports for each of the different models under varying light conditions - then we can identify which models need correcting / scaling for - ie. as I mentioned before my MBP 5,1 reports only 4 out of 255 in a reasonably well lit room so that is one candidate I would suggest - problem is that I think we'll need to be able to easily adjust it - I suggest instead what we do initially is add another sysfs file for applesmc called light_scaling or something similar which can by written to by root and that will then be used to scale the light sensor value by the driver - users can then experiment to find a good value - then for each model we can collect the scaling values which users report working well for them an integrate them into a fixed table in the driver - but we can also leave the light_scaling file available so it can be set manually still. What do you reckon?