Comment 23 for bug 274146

On Thu, Oct 02, 2008 at 02:30:44PM +0200, Sebastien Bacher wrote:
> Le jeudi 02 octobre 2008 à 11:42 +0100, Matt Zimmerman a écrit :
> > > Doing that would either require to change the upstream dialog to
> > list
> > > all the option or to add a new dialog similar to the current
> > upstream
> > > ones which list those. Changing the dialog would create a delta over
> > > upstream we will need to maintain
> >
> > All of the functions we need are already there. It's just adding an
> > entry
> > to the dialog. This is a tiny delta.
>
> right, but by doing that you will have the system, closing session and
> the shutdown entry list the duplicated actions for example. in this case
> does it still make sense to have two entries there?

I don't think it makes sense to have two entries there in the first place,
but if you are opposed to removing them, I don't think it's a problem.

> > No more so than they already are (due to the logout applet and f-u-s-a),
> > or were in previous versions of Ubuntu (due to the unified logout
> > dialog).
>
> the ubuntu changes were on the gnome-session dialog that GNOME doesn't
> use and there was a gconf key which allowed users to use the gnome-panel
> upstream dialogs instead

If that's a concern, we could make the patch 10 lines longer and still check
the same gconf key. That way, the 5 people who need that key aren't
inconvenienced, but we do the right thing for the other millions of users.

> > How so? They can still use the menu entries.
>
> you suggest patching one of the dialogs so the menu entries will have
> redundant actions, in which case in might not make sense to have several
> items listed there
>
> > There is no need for a new object; users upgrading from Hardy or early
> > Intrepid will already have the logout button at the upper right.
>
> right, it you decide to modify the upstream dialogs, in which case no
> change is required but we go back to have one dialog rather than two and
> then need to change gnome-panel and the other softwares using those

I don't consider the redundant menu entries to be as much of a problem as
having one of the most prominent buttons on the default desktop lose most of
its functionality.

--
 - mdz