sunset in clock applet does not respect 12hr/24hr setting

[Wade Menard]

Binary package hint: gnome-panel

When enabling weather and pointing at the temperature, the tooltip shows Sunrise/Sunset. However the sunset does not respect the "12 hour format/24 hour format" setting of the applet and shows it as something like "Sunset: 18:27"

Expected: the applet should translate the Sunset to 12 hour format if that is how the applet is configured.

[James Westby (james-w)]

Hi,

I can confirm this issue.

Thanks,

James

[Sebastien Bacher (seb128)]

The bug has been fixed to svn now

[Sebastien Bacher (seb128)]

the bug is fixed in hardy now

[Roberto Sarrionandia (rbs-tito)]

Sebastien - It is certainly not fixed in my install of Hardy.

[grey (canisrogeris)]

Nor is it fixed in my install of Hardy.

[Michael (michael-miceli88)]

I can confirm this problem still.

[Endolith (endolith)]

Still a problem in Intrepid

[Sebastien Bacher (seb128)]

the change seems doable for karmic

[richardjennings (richardjennings)]

gnome-panel-2.26.0/applets/clock

clock-location-tile.c

612: line4 = g_strdup_printf (_("Sunrise: %s - Sunset: %s"),
          weather_info_get_sunrise (info),
       weather_info_get_sunset (info));

I suggest some logic to format the string according to 12 / 24 hour preference.

[Ted M Lin (kitlaan)]

Here's a sample patch (against Karmic's gnome-panel 2.26.2-1ubuntu1) to have the sunrise/sunset time use the clock preference (12h vs 24h). It should apply cleanly to the current version in Intrepid (untested).

The patch also requires a minimal libgweather1 version of at least 2.25.2 (i.e. a build-deb update).

[Sebastien Bacher (seb128)]

Thank you for your work there, could you add your change to the GNOME bug too for review?

[Ted M Lin (kitlaan)]

Re: Sebastien
The patch has been attached to the GNOME bug, as requested.

[Ted M Lin (kitlaan)]

The bazaar branch is based on the latest patch in gnome bugzilla. There hasn't been any progress in a while, so am planning to get it into an ubuntu package for karmic.

[Martin Pitt (pitti)]

Lightbreeze, please don't assign a bulk of bugs to teams without consulting them before.

[Martin Pitt (pitti)]

Thanks! Committed to packaging branch.

I didn't merge your's, I saw it too late. Also, I used the newer patch tagging format that Debian/Ubuntu use these days.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-panel - 1:2.29.5.1-0ubuntu2

---------------
gnome-panel (1:2.29.5.1-0ubuntu2) lucid; urgency=low

  * debian/patches/05_no_session_delay.patch:
    - don't set X-GNOME-Autostart-Phase=Panel to avoid delaying other softwares
      start on login

  [ Martin Pitt ]
  * Add 02_sunrise_sunset_time_format.patch: Fix sunrise and sunset times in
    tooltip to respect 12/24 hour format setting. Thanks to Ted M Lin!
    (LP: #197657)
  * Add 03_dnd_places_link.patch: When using Drag'n'Drop from Places menu,
    install a link launcher (.desktop file) instead of copying the entire
    directory. Thanks Marcel Stimberg! (LP: #62529)
 -- Sebastien Bacher <email address hidden> Wed, 20 Jan 2010 19:13:17 +0100