sunset in clock applet does not respect 12hr/24hr setting

Bug #197657 reported by Wade Menard
40
This bug affects 4 people
Affects Status Importance Assigned to Milestone
GNOME Panel
Fix Released
Low
One Hundred Papercuts
Low
Ted M Lin
gnome-panel (Ubuntu)
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: gnome-panel

When enabling weather and pointing at the temperature, the tooltip shows Sunrise/Sunset. However the sunset does not respect the "12 hour format/24 hour format" setting of the applet and shows it as something like "Sunset: 18:27"

Expected: the applet should translate the Sunset to 12 hour format if that is how the applet is configured.

Revision history for this message
Wade Menard (wade-ezri) wrote :
Revision history for this message
James Westby (james-w) wrote :

Hi,

I can confirm this issue.

Thanks,

James

Changed in gnome-panel:
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

The bug has been fixed to svn now

Changed in gnome-panel:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: Confirmed → Fix Committed
Changed in gnome-panel:
status: Unknown → New
Revision history for this message
Sebastien Bacher (seb128) wrote :

the bug is fixed in hardy now

Changed in gnome-panel:
status: Fix Committed → Fix Released
Revision history for this message
Roberto Sarrionandia (rbs-tito) wrote :

Sebastien - It is certainly not fixed in my install of Hardy.

Revision history for this message
grey (canisrogeris) wrote :

Nor is it fixed in my install of Hardy.

Changed in gnome-panel:
status: Fix Released → Triaged
Revision history for this message
Michael (michael-miceli88) wrote :

I can confirm this problem still.

Revision history for this message
Endolith (endolith) wrote :

Still a problem in Intrepid

Mat Tomaszewski (mat.t.)
Changed in hundredpapercuts:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

the change seems doable for karmic

Changed in gnome-panel (Ubuntu):
milestone: none → ubuntu-9.10
Revision history for this message
richardjennings (richardjennings) wrote :

gnome-panel-2.26.0/applets/clock

clock-location-tile.c

612: line4 = g_strdup_printf (_("Sunrise: %s - Sunset: %s"),
          weather_info_get_sunrise (info),
       weather_info_get_sunset (info));

I suggest some logic to format the string according to 12 / 24 hour preference.

Changed in hundredpapercuts:
milestone: none → round-5
Revision history for this message
Ted M Lin (kitlaan) wrote :

Here's a sample patch (against Karmic's gnome-panel 2.26.2-1ubuntu1) to have the sunrise/sunset time use the clock preference (12h vs 24h). It should apply cleanly to the current version in Intrepid (untested).

The patch also requires a minimal libgweather1 version of at least 2.25.2 (i.e. a build-deb update).

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work there, could you add your change to the GNOME bug too for review?

Revision history for this message
Ted M Lin (kitlaan) wrote :

Re: Sebastien
The patch has been attached to the GNOME bug, as requested.

Changed in hundredpapercuts:
status: Confirmed → In Progress
assignee: nobody → Ted M Lin (kitlaan)
Revision history for this message
Ted M Lin (kitlaan) wrote :

The bazaar branch is based on the latest patch in gnome bugzilla. There hasn't been any progress in a while, so am planning to get it into an ubuntu package for karmic.

Changed in gnome-panel (Ubuntu):
milestone: ubuntu-9.10 → ubuntu-10.04
Changed in hundredpapercuts:
milestone: round-5 → r1
Changed in hundredpapercuts:
assignee: Ted M Lin (kitlaan) → Canonical Desktop Team (canonical-desktop-team)
Revision history for this message
Martin Pitt (pitti) wrote :

Lightbreeze, please don't assign a bulk of bugs to teams without consulting them before.

Changed in hundredpapercuts:
assignee: Canonical Desktop Team (canonical-desktop-team) → nobody
assignee: nobody → Ted M Lin (kitlaan)
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Committed to packaging branch.

I didn't merge your's, I saw it too late. Also, I used the newer patch tagging format that Debian/Ubuntu use these days.

Changed in gnome-panel (Ubuntu):
status: Triaged → Fix Committed
Vish (vish)
Changed in hundredpapercuts:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-panel - 1:2.29.5.1-0ubuntu2

---------------
gnome-panel (1:2.29.5.1-0ubuntu2) lucid; urgency=low

  * debian/patches/05_no_session_delay.patch:
    - don't set X-GNOME-Autostart-Phase=Panel to avoid delaying other softwares
      start on login

  [ Martin Pitt ]
  * Add 02_sunrise_sunset_time_format.patch: Fix sunrise and sunset times in
    tooltip to respect 12/24 hour format setting. Thanks to Ted M Lin!
    (LP: #197657)
  * Add 03_dnd_places_link.patch: When using Drag'n'Drop from Places menu,
    install a link launcher (.desktop file) instead of copying the entire
    directory. Thanks Marcel Stimberg! (LP: #62529)
 -- Sebastien Bacher <email address hidden> Wed, 20 Jan 2010 19:13:17 +0100

Changed in gnome-panel (Ubuntu):
status: Fix Committed → Fix Released
Vish (vish)
Changed in hundredpapercuts:
status: Fix Committed → Fix Released
Changed in gnome-panel:
importance: Unknown → Low
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.