no libgnome deps

Bug #97642 reported by Jani Monoses
2
Affects Status Importance Assigned to Milestone
gnome-mount (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: gnome-mount

a debdiff containing patch from upstream svn to get a local copy of GnomePasswordDialog and do not depends on libgnome any longer. autoreconf needed (500K patch unfortunately) and no shlibs generation for libgnome-mount so the package deps are not including the nautilus bits.

Related branches

Revision history for this message
Jani Monoses (jani) wrote :

the debdiff

Martin Pitt (pitti)
Changed in gnome-mount:
assignee: nobody → pitti
status: Unconfirmed → Confirmed
Revision history for this message
Jani Monoses (jani) wrote :

added milestone feisty as xubuntu gnome-mount spec depends on it

Revision history for this message
Martin Pitt (pitti) wrote :

This patch seems to be busted:

$ sudo src/gnome-mount -vbd /dev/hda3
Segmentation fault (core dumped)

#0 0x00002aaea9830c4a in ?? () from /lib/libc.so.6
#1 0x00002aaea982e522 in atoi () from /lib/libc.so.6
#2 0x0000000000409d0d in main (argc=3, argv=0x7fff03024688) at gnome-mount.c:2708

Changed in gnome-mount:
status: Confirmed → Fix Committed
status: Fix Committed → Needs Info
Revision history for this message
Jani Monoses (jani) wrote :

hmm, it worked when I tested it Iĺl have another look after reapplying it against current 0ubuntu6.

Revision history for this message
Jani Monoses (jani) wrote :

I checked again, both the original and the same debdiff against ubunt6 (which should not affect it at all since it's only removing tow printfs) and still works without crashing. This is on x86.
I have not idea why it would crash. The modified code is only used when popping up a dialog for getting a password for encrypted volumes. The other change is using gtk_init but that to works here.

Revision history for this message
Martin Pitt (pitti) wrote :

Gotcha! It just was a missing #include <stdlib.h>. The gnome headers already did that apparently.

Changed in gnome-mount:
status: Needs Info → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

 gnome-mount (0.5-2ubuntu7) feisty; urgency=low
 .
   [ Jani Monoses ]
   * debian/patches/07_gnome_password_dialog.patch:
       Patch from upstream svn, import a local copy of GnomePasswordDialog
       and drop the GNOME library dependencies (LP: #97642)
   * debian/patches/99_autoreconf:
       autotools rerun
   * debian/rules:
       make dh_shlibdeps ignore libgnome-mount so the package does not hard
       depend on libgnome.
 .
   [ Martin Pitt ]
   * debian/patches/03_root_mounting.patch: Add #include <stdlib.h> to make
     getenv() available again.

Changed in gnome-mount:
status: Fix Committed → Fix Released
Revision history for this message
Jani Monoses (jani) wrote :

thanks for catching it! I have just set up an amd64, reproduced the crash and started debugging but too late it seems :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.