Comment 10 for bug 874501

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

I'm a bit concerned about this change:

+commit bc01094411d724470ebda56d4515f45760f8d008
+Author: Stef Walter <email address hidden>
+Date: 2011-10-20
+
+ secret-store: Return results with the most recent result first
+
+ * This is to help programs that have erroneusly stored more than
+ one password with given attributes, and keep finding the old one.
+ * The most recent one is usually correct.
+
+ pkcs11/secret-store/gkm-secret-search.c | 79 +++++++++++++----------
+ pkcs11/secret-store/tests/test-secret-search.c | 73 ++++++++++++++++++++++
+ 2 files changed, 118 insertions(+), 34 deletions(-)
+

And the lack of a "regression potential" attached to this bug. I'd like to see some comments on what the danger is here, as to me, this seems like a clear change in the way it works, and might cause regressions for applications which don't expect them to be in this order.

Leaving it in the queue for now, but can somebody please add a full SRU justification to the bug description?

https://wiki.ubuntu.com/StableReleaseUpdates