Wording of keyring access dialog could be improved

Bug #18384 reported by James Bennett
46
This bug affects 5 people
Affects Status Importance Assigned to Milestone
GNOME Keyring
Confirmed
Medium
gnome-keyring (Ubuntu)
Low
Ubuntu Desktop Bugs

Bug Description

The dialog which asks whether an application should be granted access to the
keyring could be improved with a couple of minor changes:

1. The button which is currently labeled 'Deny' should be relabeled 'Don't
Allow'. The dominant verb in this dialog is 'Allow', and 'Allow' appears in the
labels of both of the other buttons, so for consistency's sake it should appear
here as well.

2. Currently the full path of the application which is requesting access is
displayed in the dialog text, e.g., "The application 'File Manager'
(/usr/bin/nautilus) wants to access..." This is unnecessary and may prove
confusing to users who will, at most, only be interested in the name of the
application which is attempting to access the keyring. So the path should not be
displayed in this dialog.

http://bugzilla.gnome.org/show_bug.cgi?id=308974: http://bugzilla.gnome.org/show_bug.cgi?id=308974

Revision history for this message
James Bennett (jbennett) wrote :

Created an attachment (id=2822)
Mockup for comparison

Mockup showing the current version of the dialog, and a version with the
suggested changes.

Revision history for this message
James Bennett (jbennett) wrote :

Created an attachment (id=2823)
Rough patch

Patch which should implement these changes; doesn't cover the i18n files which
will need to be changed later if this goes anywhere.

Revision history for this message
James Bennett (jbennett) wrote :

Created an attachment (id=2825)
Corrected patch

Corrected patch, should work now.

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks for your bug, I've forwarded it upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=308974

Matt Zimmerman (mdz)
Changed in gnome-keyring:
status: Unconfirmed → Confirmed
Changed in gnome-keyring:
assignee: nobody → desktop-bugs
Revision history for this message
Sebastien Bacher (seb128) wrote :

comment from upstream:

"The pathname is something you can trust, whereas the name is whatever the app
sent, so if we drop the pathname there is zero security."

Changed in gnome-keyring:
importance: Medium → Low
Changed in gnome-keyring:
status: Confirmed → Triaged
Changed in gnome-keyring:
status: New → Confirmed
Revision history for this message
Ijan (yournamehere-gmx) wrote :

I've got a bug (in Jaunty RC) that might be related to this one and somebody directed me here, so I hope it's ok to post it here, or should I have filed it individually?

Problem: right after login I get a dialog box by the Gnome-keyring to grant access to some "application" that is neither identified by appname nor by a path. Also there is no other visual indication which application this might refer to. I added a screenshot to clarify.

Revision history for this message
Ijan (yournamehere-gmx) wrote :

Update: The above mentioned bug does only reproduce in the german localisation of Ubuntu and seems to refer to keyring access of Evolution. I checked the english and french localisation which gave path and appname correctly. Sorry, I'm new to bug reporting.

David Futcher (bobbo)
tags: added: patch-forwarded-upstream
Changed in gnome-keyring:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.