Comment 4 for bug 305791

Hi Sebastien,

Okay, it took me quite a while (and a lot of games) to recreate the situation. However, I finally got it and I've attached two screen shots of (1) a game in progress, and (2) the "problem" condition.

The solution is something along the lines of checking a rule before clicking on the "face down" pile to deal new cards:

if ( number_of_empty_piles > 0 && number_of_cards > number_of_piles )
{
   issue_warning();
   return;
}

Currently, it behaves like:
if ( number_of_empty_piles > 0 )
{
   issue_warning();
   return;
}

Thanks,

Dave.

--- On Thu, 12/18/08, Sebastien Bacher <email address hidden> wrote:

> From: Sebastien Bacher <email address hidden>
> Subject: [Bug 305791] Re: Aisleriot solitaire can't advance - spider
> To: <email address hidden>
> Date: Thursday, December 18, 2008, 5:51 AM
> the description is not really clear on what you try to do,
> could you add
> a screenshot showing the issue?
>
> --
> Aisleriot solitaire can't advance - spider
> https://bugs.launchpad.net/bugs/305791
> You received this bug notification because you are a direct
> subscriber
> of the bug.
>
> Status in “gnome-games” source package in Ubuntu:
> Incomplete
>
> Bug description:
> Binary package hint: gnome-games
>
> Aisleriot Solitaire, playing Spider (1 suit in this case).
> Game progressed with complete "stacks" played to
> top leaving only 3 cards in the main playing area and still
> 1 more round of cards in the stock. Can't deal from
> stock because rule (improperly applied) and message saying
> to fill in empty piles first. There aren't enough cards
> to fill all 10 pile spots.
>
> Package info:
> gnome-games:
> Installed: 1:2.22.3-0ubuntu2
> Candidate: 1:2.22.3-0ubuntu2
> Version table:
> *** 1:2.22.3-0ubuntu2 0
> 500 http://us.archive.ubuntu.com hardy-updates/main
> Packages
> 100 /var/lib/dpkg/status
> 1:2.22.1.1-0ubuntu3 0
> 500 http://us.archive.ubuntu.com hardy/main
> Packages
>
> This seems like a pure application bug, but here's
> system info:
> Ubuntu, 8.04.1
> kernel 2.6.24-22-generic
> 3GHz Intel CPU
> ATI Radeon X600 video
> 2MB RAM